-
# C4-001 : The Contract Should approve(0) first
## Impact - LOW
Some tokens (like USDT L199) do not work when changing the allowance from an existing non-zero allowance value.
They must first be a…
-
Issue: `Require` message is too long
Explanation: The `require` revert strings below can be shortened to 32 characters or fewer (as shown) to save gas
All four lines referenced below incorporate the …
-
## Loss Of Precision
This issue is about arithmetic computation that could have been done more percise.
The following are places in the codebase in which you multiplied after the divisions.
Doing…
-
# C4-001 : Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom
## Impact
It is good to add a require() statement that checks the return value of token transfers or to us…
-
Has anyone ever evaluated the accuracy of load_xdf's drift correction algorithm? It is a non-standard algorithm (i.e. not part of Matlab) for fitting a first order curve to correct for clock drift bet…
-
# [G-01] Redundant zero initialization
Solidity does not recognize null as a value, so uint variables are initialized to zero. Setting a uint variable to zero is redundant and can waste gas.
Locatio…
-
Location: [Libera.chat, #monero-research-lab](https://libera.chat/) | [Matrix](https://matrix.to/#/#monero-research-lab:monero.social?via=matrix.org&via=monero.social)
[Join the Monero Matrix serve…
-
# ISSUE LIST
#### C4-001: Missing events for only functions that change critical parameters - Non Critical
#### C4-002 : Critical changes should use two-step procedure - Non Critical
#### C4-003 : Pr…
-
# C4-001 : transferOwnership should be two step process
## Impact - LOW
"LiquidityFarming" inherit OpenZeppelin's OwnableUpgradable contract which enables the onlyOwner role to transfer ownership to…
-
# C4-001 :Use safeTransfer/safeTransferFrom consistently instead of transfer/transferFrom
## Impact - LOW
## Impact
It is good to add a require() statement that checks the return value of token tr…