-
As mentioned in https://github.com/rust-bitcoin/rust-miniscript/pull/481#discussion_r1028718255, it appears that the planning module doesn't include the varint length for `TapScript` and `TapControlBl…
-
In `Witness` we have three methods for getting at parts of the witness stack for Taproot transactions.
- `tapscript`
- `taproot_control_block`
- `taproot_annex`
We could consider combining the…
-
Not sure if it's related here, but I have an issue with the [`control_block`](https://github.com/rust-bitcoin/rust-bitcoin/blob/73e33e58089b23bf8f46ef6d54f40972d9e2d333/bitcoin/src/tapro…
-
Remove the #[allow(deprecated)] from the rustdocs of sha256t_hash_newtype and run `just lint` - gives a warning. But CI passed on https://github.com/rust-bitcoin/rust-bitcoin/pull/3528 without it.
-
There is some debate about what benefit/costs serde's `derive` feature gives us. Before releasing `primitives` we should re-visit the topic and make a decision.
Original discussion is in https://gi…
-
The rust-bitcoin project has been pretty reckless with API breaks. This trend started about a couple of years ago. API breaks introduce costs **and risks** to downstream projects. Some of these projec…
-
Right now there are two versions one from the `bdk` crate and another imported directly.
This is mentioned in #38
> We're using two different version of rust-bitcoin throughout the project. One…
-
I've been considering an alternative approach to writing a Bitcoin Core JSON RPC client, namely, exporting the structured API information available within Bitcoin Core as JSON, and using that to auto-…
-
`MIN_RELAY_FEE_SAT_PER_1000_WEIGHT` is used to enforce a minimum fee bump for transaction RBFs. Per Bitcoin Core policy, this should be 1 sat/vB. Instead, we're using 16 sat/vB:
https://github.co…
-
These panics are caused by us storing indices as `u32` rather than `usize` and we forgot to document it.
Possible solutions:
* store `usize` indices
* keep panics and document them, also make t…