ACCESS-NRI / access-hive.org.au

Documentation hub for the Earth System models, ACCESS, and their community
https://access-hive.org.au/
8 stars 12 forks source link

Update ACCESS-OM2 run instructions #653

Closed aidanheerdegen closed 3 months ago

aidanheerdegen commented 4 months ago

Description

Updates ACCESS-OM2 model run instructions for ACCESS-OM2 Flagship Release.

Fixes #650

This also works if you include the same text in a commit message.

Checklist:

github-actions[bot] commented 4 months ago

PR Preview :---: 🛬 Link removed because the pull request was closed. 2024-04-12 16:34 AEST

aidanheerdegen commented 4 months ago

This is a draft because I haven't finished it.

aidanheerdegen commented 4 months ago

Hrm. The !!! note things seemed to not be working. I have got some to work sometimes.

They're admonitions in mkdocs-material theme

https://squidfunk.github.io/mkdocs-material/reference/admonitions/

anton-seaice commented 4 months ago

I assume these commits will get squashed during the merge :)

aidanheerdegen commented 4 months ago

I assume these commits will get squashed during the merge :)

Yes, they're not at all functional as commits.

aidanheerdegen commented 4 months ago

Sorry - lots of comments but mostly minor I hope :)

No, thank you. A fresh perspective is much appreciated.

If you have time and while it is fresh could you take a look at the amended version to make sure you're happy with the changes and if you think of anything else that'd be great.

anton-seaice commented 4 months ago

Just this bit of formatting is off:

Screen Shot 2024-03-19 at 1 11 55 pm

aidanheerdegen commented 4 months ago

Just this bit of formatting is off

Fixed. Thanks. I believe I've also addressed all the out-standing comments.

And thank you for the thorough and time-consuming review.

anton-seaice commented 4 months ago

No worries . All looks good Aidan.

aidanheerdegen commented 4 months ago

Thanks for the review @minghangli-uni. Really useful suggestions and I believe I have incorporated them all.

aidanheerdegen commented 3 months ago

@atteggiani I have pinged you for a review. If you can't manage it today can you let me know, as I'd like this to go live this afternoon.

Thanks!

atteggiani commented 3 months ago

Hi @aidanheerdegen, I am checking the PR and content-wise is all good, but there are many (little) things that need to be modified for the style and consistency with the other pages.

My plan is the following:

  1. I create a branch called davide/review-PR-OM2 from this branch (aidanheerdegen/issue650)
  2. I do the modifications in my new branch
  3. I open a PR to merge my new branch (davide/review-PR-OM2) into this branch (aidanheerdegen/issue650)
  4. You review the PR so we merge the two branches
  5. We merge this (updated) PR to development

The whole process should not take more than 1-2 hours.