Closed aidanheerdegen closed 3 months ago
PR Preview :---: 🛬 Link removed because the pull request was closed. 2024-04-12 16:34 AEST
This is a draft because I haven't finished it.
Hrm. The !!! note
things seemed to not be working. I have got some to work sometimes.
They're admonitions in mkdocs-material theme
https://squidfunk.github.io/mkdocs-material/reference/admonitions/
I assume these commits will get squashed during the merge :)
I assume these commits will get squashed during the merge :)
Yes, they're not at all functional as commits.
Sorry - lots of comments but mostly minor I hope :)
No, thank you. A fresh perspective is much appreciated.
If you have time and while it is fresh could you take a look at the amended version to make sure you're happy with the changes and if you think of anything else that'd be great.
Just this bit of formatting is off:
Just this bit of formatting is off
Fixed. Thanks. I believe I've also addressed all the out-standing comments.
And thank you for the thorough and time-consuming review.
No worries . All looks good Aidan.
Thanks for the review @minghangli-uni. Really useful suggestions and I believe I have incorporated them all.
@atteggiani I have pinged you for a review. If you can't manage it today can you let me know, as I'd like this to go live this afternoon.
Thanks!
Hi @aidanheerdegen, I am checking the PR and content-wise is all good, but there are many (little) things that need to be modified for the style and consistency with the other pages.
My plan is the following:
davide/review-PR-OM2
from this branch (aidanheerdegen/issue650
)davide/review-PR-OM2
) into this branch (aidanheerdegen/issue650
)The whole process should not take more than 1-2 hours.
Description
Updates ACCESS-OM2 model run instructions for ACCESS-OM2 Flagship Release.
Fixes #650
This also works if you include the same text in a commit message.
Checklist: