ACCESS-NRI / access-hive.org.au

Documentation hub for the Earth System models, ACCESS, and their community
https://access-hive.org.au/
8 stars 12 forks source link

MED review and restructure #663

Closed flicj191 closed 1 month ago

flicj191 commented 3 months ago

Description

Restructure MED section, renaming files so is easier to navigate for editing. Formatting and styling fixes

If this pull request addresses an already open issue, then you can link that issue with this syntax:

Fixes #644 #645 #525

Type of change

Checklist:

When your pull request is ready please request a review.

Unless there is a specific person you want to review your PR please select the reviewers team: ACCESS-Hive/reviewers. This ensures the load for reviewing pull requests is shared equitably.

github-actions[bot] commented 3 months ago

PR preview :---: ⚠️ There was an error in the pr-preview deployment. For more information, please check the Actions tab. 2024-06-19 12:56 AEST

flicj191 commented 3 months ago

Hi @paigem when you get a moment are you able to give a read through the content here? You should be able to use the PR preview to look at the MED section. I have moved paragraphs around and added a few things but ultimately using what was already there. More could be cut out if out of place or irrelevant or add back in. When you get back and have some time we can catch up if you like.

atteggiani commented 3 months ago

Thank you @flicj191 for the massive work on this.

There are a few minor modifications I would put in place (mostly regarding style rather than content). I think it'd be easier (and quicker) if I apply the modifications myself starting from your branch as a base point.

What I am going to do is create another branch (starting from this one) where I will place my modifications. I will then open a PR to merge my branch into this one. Then we can follow through with this PR to merge this (updated) branch to development.

Thank you!

paigem commented 3 months ago

@flicj191 I'm happy to review! FYI I will get to this mid-next week at the earliest.

atteggiani commented 2 months ago

Thanks for the thorough review @paigem.

I added some comments to your review, but overall I agree with all the points.

I will start adding my review as well, but as I mentioned above, I will create a different branch from this one, and open a PR to this branch (because there will be a lot of structural/style changes since I will be converting everything that is possible to markdown).

flicj191 commented 1 month ago

Marking as ready for review for merging a first pass and can open new PR's for more specific fixes and details. such as

@atteggiani @KAUR1984 what do you think? have a look

atteggiani commented 1 month ago

Marking as ready for review for merging a first pass and can open new PR's for more specific fixes and details. such as

  • links formatting
  • image fixing
  • content discussions with specific people
  • moving community resources links here
  • med specific getting started (conda environments info to add to getting started sections?)

@atteggiani @KAUR1984 what do you think? have a look

I am ok with that! Thank you @flicj191