ACCESS-NRI / access-hive.org.au

Documentation hub for the Earth System models, ACCESS, and their community
https://access-hive.org.au/
8 stars 11 forks source link

Changed entire website to Markdown + new link checker #679

Closed atteggiani closed 4 months ago

atteggiani commented 5 months ago

This is another very big PR, where the following changes have been made:

I understand the number of changed files is massive, but in most files content does not change much (only syntax). What I suggest for the review, apart from looking at the changes themselves, is to compare the PR-preview website to the Development website. Most pages should be exactly the same despite the changes in the syntax.

github-actions[bot] commented 5 months ago

PR preview :---: ⚠️ There was an error in the pr-preview deployment. For more information, please check the Actions tab. 2024-05-10 14:27 AEST

atteggiani commented 5 months ago

looked at the preview and layout is looking good, apart from the comment on the user support page I put in. noting with the absolute links in the cards it goes to main live site instead of the pr-preview but navigating on the left is fine to check the pages.

Yes thank you for pointing it out.

I realized it in fact I already solved it both in development (I forced push) and in this branch. Now everything works as supposed to.

There are a few caveats to that: In order to make it work, an additional javascript function needed to be implemented to change the absolute links if on the development-website or any pr-preview website. This works fine, but adds time for the page to load (not appreciable if you have an at least modest connection), even for the main website. For now I think is fine (again, it does not add much time) but, in general, many of these functions (currently embedded as a separate javascript file in js/miscellaneous.js) should take place in the build process instead, because they interact with things that cannot be altered by users. In the near future we will need to discuss the best approach to restructure the build process and customize the build so that all these changes will not influence the loading time for the pages.

@flicj191 @heidinett @KAUR1984

atteggiani commented 5 months ago

Thanks for the speedy and review @heidinett!

atteggiani commented 4 months ago

Thanks a lot @heidinett, @flicj191 and @KAUR1984 for the reviews! Merging this :)