ACCESS-NRI / access-hive.org.au

Documentation hub for the Earth System models, ACCESS, and their community
https://access-hive.org.au/
8 stars 11 forks source link

683 update access esm how to run #726

Closed blimlim closed 2 months ago

blimlim commented 2 months ago

Description

This pull request updates the run access esm tutorial to match the structure of the OM2 tutorial, and to include changes related to the latest payu updates and the (to be) released configurations.

The new ESM how to run page was set up by copying the OM2 page, and modifying the information to be correct for ESM1.5.

This is not currently ready to merge, as some changes cannot be made until the final release, specifically:

In the mean time though, it would be great to get feedback and suggestions on the other changes!

Fixes #683

Type of change

Checklist:

github-actions[bot] commented 2 months ago

PR preview :---: 🛬 Preview link removed because the pull request was closed.

blimlim commented 2 months ago

Hi everyone, I've finally finished adding in some of the more ESM1.5 specific information now that the changes to the configurations and payu are (mostly) finalised and I think it's ready for a review.

The following two points are still waiting on further information/links, but everything else should be ready for a review:

Sorry about the delay on this!

KAUR1984 commented 2 months ago

Thanks for that @blimlim! Looks great to me!

I would perhaps suggest to merge this PR into the development branch for now. For the rest of the changes, happy to create a new PR and once we have all the changes, we can deploy it on the main branch. :)

blimlim commented 2 months ago

Thanks @KAUR1984! I just realised there were a couple of spelling errors which I've just fixed up, and then will merge into development

aidanheerdegen commented 2 months ago

I'm part way through reviewing. Should I just close off that review and allow you to make the suggested changes?

blimlim commented 2 months ago

That sounds good! I'll wait until I've added any suggested changes before merging.

blimlim commented 2 months ago

Thanks for spotting those things – I think they're all good suggestions and I've added them in.

I have some thoughts about the post-processing, but that may require changes to the script invocation, which will then have to be changed here to be consistent.

Sounds good, lets see if we can simplify how the script is called.

blimlim commented 2 months ago

I've just updated the docs with the change to the NetCDF conversion behaviour and added in the correct payu version. After looking over everything, I think the information is now correct.