search

ACCESS-NRI / access-hive.org.au

Documentation hub for the Earth System models, ACCESS, and their community
https://access-hive.org.au/
8 stars 11 forks source link

Changed all 'Hive' references to properly address the Docs and Forum.… #746

Closed atteggiani closed 2 months ago

atteggiani commented 2 months ago

Fixes #733. Fixes #724.

Fixes #723. The image has been removed for now. A new image might be produced in the future, but I would not deem it necessary for the moment (before the workshop).

github-actions[bot] commented 2 months ago

PR preview :---: 🛬 Preview link removed because the pull request was closed.

KAUR1984 commented 2 months ago

Thanks for your work on this PR @atteggiani ! Looks great to me! Just a minor comment on the PR, if possible, it would be great to have just one issue for one PR. I see this PR is a bigger one and it might be a bit hard to review for someone who is not actively developing on it.

In case one issue per PR is not possible in some cases, it would be really helpful to have a checklist in the PR description for what issues have been addressed, so everyone else is aware of the changes at a glance, and would not create any new issues for things that have already been addressed in a PR. :)

I was about to create a new issue on changing the ACCESS-Hive heading to ACCESS-Hive docs, but realised that this has already been addressed in this PR (and there was no existing issue in the board).

KAUR1984 commented 2 months ago

If there is an issue that would require a huge PR, we might benefit from breaking that issue into smaller ones :)

atteggiani commented 2 months ago

Just a minor comment on the PR, if possible, it would be great to have just one issue for one PR. I see this PR is a bigger one and it might be a bit hard to review for someone who is not actively developing on it.

Thank you Jasmeen for the comment. You are right, it would be ideal to have one single issue for every PR. However, in this case, the Issues listed are effectively subissues of the main one (#733).

In case one issue per PR is not possible in some cases, it would be really helpful to have a checklist in the PR description for what issues have been addressed, so everyone else is aware of the changes at a glance, and would not create any new issues for things that have already been addressed in a PR. :)

Yeah I agree. If a situation like this happens again in the future (very likely), I will make the description of the PR more detailed! :)

I was about to create a new issue on changing the ACCESS-Hive heading to ACCESS-Hive docs, but realised that this has already been addressed in this PR (and there was no existing issue in the board).

Again, there is no specific issue because I thought it would be better (and cleaner) to address the naming problems all at once (so as not to forget anything and because it's the same conceptual fix).