AEFeinstein / mtg-familiar

An Android app for all things Magic: The Gathering
Other
280 stars 72 forks source link

Complete Translation for Rules, Cards, etc #14

Open AEFeinstein opened 10 years ago

AEFeinstein commented 10 years ago

This is a pipe dream, but it would be lovely to somehow get translations for rules and the database itself, instead of having large, functional parts of the app in English only.

churrufli commented 9 years ago

Yeah, at least search in another language would be great

yringot commented 7 years ago

How about at least integrating card names in different languages? E.g. I would like to buy cards from Japanese online sellers who often only list the Japanese names of the card in their listing on ecommerce sites.

Currently I have to search for the card on magiccards.info, copy the Japanese name, and then search for that name on eBay.co.jp or whatever. It would be nice if I didn't have to do that middle step.

I'm not sure where this would be integrated into the UI though.

AEFeinstein commented 7 years ago

Card names in different languages would be more possible. They're on gatherer at least. The UI would probably be another dialog button next to the price, rulings, wishlist, etc.

This would be a two-parter. GathererScraper would need to be updated to scrape the foreign names and build the patch too.

I'm on a hiatus from development for a few months, but you're more than welcome to take a stab at this.

yringot commented 7 years ago

That sounds good, but I have no idea how to do this... :) Thank you for inviting me to cooperate, though.

I'm here in Shanghai with a bunch of other foreigners and we're regularly dealing with cards in Chinese, especially when buying singles on Taobao (=chinese ebay) where the listings are usually Chinese-only. Furthermore, I have a lot of cards in German and Spanish as well, due to being German and having spent time in a Spanish-speaking country. So multilinguality would be an awesome feature for me and for the others here.

Anyway, awesome job on the app!

Yannick

Am 01.02.2017 um 07:54 schrieb AEFeinstein:

Card names in different languages would be more possible. They're on gatherer at least http://gatherer.wizards.com/Pages/Card/Languages.aspx?multiverseid=193556. The UI would probably be another dialog button next to the price, rulings, wishlist, etc.

This would be a two-parter. GathererScraper https://github.com/AEFeinstein/GathererScraper would need to be updated to scrape the foreign names and build the patch too.

I'm on a hiatus from development for a few months, but you're more than welcome to take a stab at this.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AEFeinstein/mtg-familiar/issues/14#issuecomment-276531984, or mute the thread https://github.com/notifications/unsubscribe-auth/ADVT4lcTRHeVyJ0WIuu62VjCiOIDjVgzks5rX8m0gaJpZM4B8BbT.

yringot commented 7 years ago

Hi,

I wanted to say that I was pleasantly surprised at seeing the foreign card names in the new app version! Thank you for incorporating them.

Would it be possible to make them copyable, though? For example, by long-pressing different parts of the cards, their content can already be copied into memory/clipboard which can then be pasted elsewhere. (For example the Chinese version of Ebay.)

Would it be possible to implement that kind of functionality for the foreign names as well? I can already press them (the background of the words change color), but it seems as though it doesn't put them on the clipboard.

Anyway, it is already quite nice to have this as I can show it the Chinese names of cards to the people in the LGS so that they directly know which cards I'd like to have.

Thanks!

Am 06.02.2017 um 21:43 schrieb Yannick Ringot:

That sounds good, but I have no idea how to do this... :) Thank you for inviting me to cooperate, though.

I'm here in Shanghai with a bunch of other foreigners and we're regularly dealing with cards in Chinese, especially when buying singles on Taobao (=chinese ebay) where the listings are usually Chinese-only. Furthermore, I have a lot of cards in German and Spanish as well, due to being German and having spent time in a Spanish-speaking country. So multilinguality would be an awesome feature for me and for the others here.

Anyway, awesome job on the app!

Yannick

Am 01.02.2017 um 07:54 schrieb AEFeinstein:

Card names in different languages would be more possible. They're on gatherer at least http://gatherer.wizards.com/Pages/Card/Languages.aspx?multiverseid=193556.

The UI would probably be another dialog button next to the price, rulings, wishlist, etc.

This would be a two-parter. GathererScraper https://github.com/AEFeinstein/GathererScraper would need to be updated to scrape the foreign names and build the patch too.

I'm on a hiatus from development for a few months, but you're more than welcome to take a stab at this.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AEFeinstein/mtg-familiar/issues/14#issuecomment-276531984,

or mute the thread https://github.com/notifications/unsubscribe-auth/ADVT4lcTRHeVyJ0WIuu62VjCiOIDjVgzks5rX8m0gaJpZM4B8BbT.

AEFeinstein commented 7 years ago

Sure, made a separate ticket for that (#209)

KingSupernova31 commented 6 years ago

The full list (I think) of what's not affected by language changes:

The MTR The IPG The JAR The CR The card images The card database The “change display mode” options in the life counter

Translations of all the official documents can be found on the judge blogs: https://blogs.magicjudges.org/translatedrules

Foreign card images can be found for many cards on Gatherer, but some of them just display a card back instead. Displaying those when possible is still better than the current system I think.

AEFeinstein commented 6 years ago

There's a separate preference to select language for card images already. Unfortunately, there is no foreign Oracle text on Gatherer. Judge Docs must come in plaintext or HTML form. I'm not incorporating PDFs into Familiar. The "change display mode" text is localized. I don't know why it is still English in the French file. I'll have that retranslated.

KingSupernova31 commented 6 years ago

Is this an acceptable format? (It's the IPG in Spanish.)

MTG_IPG_19Jan18_ES.txt

XVicarious commented 6 years ago

It should be in html format.

KingSupernova31 commented 6 years ago

It's in plaintext form, which is what was asked for.

XVicarious commented 6 years ago

Ah. Ha I didn't read it sorry. I was just going off of what format it is in the source.

On Sun, Mar 11, 2018, 11:59 PM KingSupernova31 notifications@github.com wrote:

It's in plaintext form, which is what was asked for.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AEFeinstein/mtg-familiar/issues/14#issuecomment-372187904, or mute the thread https://github.com/notifications/unsubscribe-auth/AB0QvHFWrX0xFkuX-_eP-T1Wdyb8WeTOks5tdfK6gaJpZM4B8BbT .

AEFeinstein commented 6 years ago

In light of #365 I'm not sure what I'm going to do for Judge Docs. The plaintext Spanish IPG is very usable, but I'm even more hesitant to start using a data source which won't be maintained over time. How did you generate that IPG?

KingSupernova31 commented 6 years ago

I asked the head of the translation project and he provided it. If it's useful to you, I can see about getting the project to release document in that format in addition to the PDFs they currently put out.