search

AEFeinstein / mtg-familiar

An Android app for all things Magic: The Gathering
Other
281 stars 72 forks source link

Add prerelease promo pricing #156

Open AEFeinstein opened 7 years ago

AEFeinstein commented 7 years ago

In the meantime, have you considered adding a "prerelease" set so we can query those cards as well when pricing things? I know trying to accommodate every possible promo situation probably isn't worthwhile and there was a time when a single prerelease card per set didn't make sense to build a category for but with every rare and mythic in every set now having prerelease versions, there's enough volume that it makes sense.

XVicarious commented 7 years ago

Have you ever thought of building the database from a source other than Gatherer? It is antiquated and doesn't have a proper API. Scryfall has an API and has not only promo sets, but online sets. It also includes legalities for formats like Pauper. Unfortunately we would still have to get ruling information from Gatherer, as that is not included in the data pulled from Scryfall.

AEFeinstein commented 7 years ago

Gatherer may be antiquated, but it is the only source for official Oracle text. Every other source is copying from Gatherer too (and sometimes adding a little extra spice). I'm just avoiding middlemen and reducing dependencies on other data sources.

On Wed, Feb 15, 2017 at 12:15 PM Brian Maurer notifications@github.com wrote:

Have you ever thought of building the database from a source other than Gatherer? It is antiquated and doesn't have a proper API. Scryfall has an API https://scryfall.com/docs/api-overview and has not only promo sets, but online sets. It also includes legalities for formats like Pauper. Unfortunately we would still have to get ruling information from Gatherer, as that is not included in the data pulled from Scryfall.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AEFeinstein/mtg-familiar/issues/156#issuecomment-280074878, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOHDOr4GvVS29vUppz3KTvmxBPBSrw0ks5rczK6gaJpZM4L_VRg .

KingSupernova31 commented 6 years ago

MTGJSON has already done all the work of adding promos, improving formatting, and fixing errors found in Gatherer. They're used by a ton of sites and apps, they aren't going to shut down any time soon. Don't reinvent the wheel. :)

AEFeinstein commented 6 years ago

I did not reinvent any wheels because Familiar predates MTGJSON. You also can't guarantee that MTGJSON won't disappear like their sister site MTGIMAGE did.

XVicarious commented 6 years ago

It should be noted that MTGJSON IS open source. So even if it does disappear, we can still use it.

AEFeinstein commented 6 years ago

This is true. I guess it comes down to the fact that I have a tool and workflow that works, is easy to maintain (to me), and is tightly integrated. It's not worth my time to switch over.