AI-SDC / SACRO-Viewer

A tool for fast, secure and effective output checking, which can work in any TRE.
Other
2 stars 1 forks source link

Stop suppressing failing cells #178

Closed benbc closed 1 year ago

benbc commented 1 year ago

ACRO v0.3.0 introduces a change to handling of disclosive cells in tables. They are no longer suppressed by default. This is so that output checkers can override ACRO and approve tables with (for example) small numbers for release if they agree that the data is not disclosive.

This behaviour is configurable (by a parameter to ACRO()), but the new default is not to suppress.

As well as taking v0.3.0 to get this change, we need to change the way that we display failing cells. Currently we put the details of the failure into the cell; we want to display the number there now, so we will need to decorate it with the details in some other way (for example as a tooltip).

Note: we have previously held off on taking v0.3.0 because of a format change, but actually it's fine to take it (see #145 for details).