ALT-F4-LLC / kickstart.nix

Kickstart your Nix environment.
Apache License 2.0
166 stars 35 forks source link

Add dart template #48

Closed SecretVal closed 7 months ago

SecretVal commented 7 months ago

Changes

SecretVal commented 7 months ago

Okay now it's right. I somehow managed to delete template/dart/flake.nix.

hbjydev commented 7 months ago

@SecretVal Can you pls update .github/workflows/flake-language.yml with the new dart entry too so that we can have CI auto-test it? Thanks :)

hbjydev commented 7 months ago

File in main: https://github.com/ALT-F4-LLC/kickstart.nix/blob/main/.github/workflows/flake-language.yml

hbjydev commented 7 months ago

Think something's broken with this build @SecretVal -- See this workflow run.

Was seeing a lot of times where either Nix or Dart was trying to read files in /etc and /boot, which it won't be able to do in the Nix sandbox iirc.

SecretVal commented 7 months ago

It's complaining that it cant find jq and if I add it, it works.

hbjydev commented 7 months ago

Thanks for your PR, buddy :) Merging once this test suite passes

SecretVal commented 7 months ago

Is it normal that the nixos desktop fails? I don't think that I have changed anything that could cause that.

hbjydev commented 7 months ago

Giving it a kick

erikreinert commented 7 months ago

Yup, it's flakey from time to time and needs a kick. Thank you for contributing! Merging now.

hbjydev commented 7 months ago

@erikreinert Just had a thought btw -- obviously Val was able to sort with a bit of a push in the right direction, but should we make a CONTRIBUTING.md file that points out that you need to update the various .github/workflows files depending on your changes?

SecretVal commented 7 months ago

@erikreinert Just had a thought btw -- obviously Val was able to sort with a bit of a push in the right direction, but should we make a CONTRIBUTING.md file that points out that you need to update the various .github/workflows files depending on your changes?

Would be nice. I was kinda confused on what I need to change.