search

ALT-F4-LLC / kickstart.nix

Kickstart your Nix environment.
Apache License 2.0
166 stars 35 forks source link

Enhance docker #59

Closed bogdan556 closed 6 months ago

bogdan556 commented 6 months ago
Sironheart commented 6 months ago

I'd say the PR in its current form isn't really well-thought-out. I don't see the benefit for a 'quick starting point'. This might be useful for the Shell Application, but most other examples are just getting way more complex, without real-world benefit, I feel. Of course, this is on @erikreinert to decide.

hbjydev commented 6 months ago

Hiya -- I'm agreed with @Sironheart here, a lot of these changes don't really make much sense in the context of this repo. Especially the Go ones, they don't really need dependencies (copyToRoot).

Also, you've added Just configs to a lot of the templates, but we've made a conscious decision in Kickstart to not be opinionated about this; better that people learn Nix with this repo than how to use Just.

I'm gonna be closing this PR, but if you want to re-address these points and submit a different set of changes, go for it. PRs are always appreciated, and I hope I don't seem like I'm just rejecting your PR for no reason :)