search

AMNS / Nightingale

Nightingale music notation software.
Mozilla Public License 2.0
11 stars 3 forks source link

Debug Display of some subobjects shows garbage #185

Closed donbyrd closed 3 years ago

donbyrd commented 3 years ago

For string Graphics, Debug Display of subobjects shows the string as something like "0x1b1494"; for Slurs, it shows control points as "P P P P". There are probably other booboos like this in Debug Display. The format strings passed to LogPrintf for these use "%p" or "%P" conversions, which make no sense in C99; they're undoubtedly relics of when Nightingale used a library of Doug McKenna's to display messages.

donbyrd commented 3 years ago

I've fixed the display of control points for slurs; not yet committed/pushed to the repository. The display of string Graphics is the only other occurrence of "%p" or "%P" in the code and very likely the only other place we show garbage.

donbyrd commented 3 years ago

I've fixed the display of string Graphics. Again not pushed to the repository yet.

donbyrd commented 3 years ago

Pushed the fix.