search

AMZ-Racing / fssim

Formula Student Simulator dedicated for FSD competition
MIT License
238 stars 87 forks source link

Blend speed fix #4

Closed ValerioMagnago closed 5 years ago

ValerioMagnago commented 5 years ago

At speed greater than 1 m/s the acceleration of the model was double of the correct one since the speed increase predicted by the kinematic model was always added to the speed predicted by the dynamical model.

Added parentheses and arranged the precedence between the operations in the function f_kin_correction used to blend the kinematic with the dynamic model at low speed.

kabzo commented 5 years ago

@ValerioMa thanks for opening this. Why did you close it? I was about to look into it.

ValerioMagnago commented 5 years ago

Oh sorry, I messed up a little bit with previous pull request and so I delete it and I have opened a new cleaner one!

Da: Juraj Kabzan notifications@github.com Inviato: sabato 22 giugno 2019 11:25 A: AMZ-Driverless/fssim Cc: Valerio Magnago; Mention Oggetto: Re: [AMZ-Driverless/fssim] Blend speed fix (#4)

@ValerioMahttps://github.com/ValerioMa thanks for opening this. Why did you close it? I was about to look into it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/AMZ-Driverless/fssim/pull/4?email_source=notifications&email_token=AEJ4WCWO6324ZJDZLRCVRE3P3XVX3A5CNFSM4HZ2SA5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYKFHRA#issuecomment-504648644, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEJ4WCX5P355MO6MQC4YTC3P3XVX3ANCNFSM4HZ2SA5A.