search

ARM-software / arm-enterprise-acs

ARM Enterprise ACS
Apache License 2.0
42 stars 52 forks source link

FWTS: Fix DBG2 SBBR test to allow 16550 #109

Closed samerhaj closed 3 years ago

samerhaj commented 3 years ago

FWTS is restricting SBBR DBG2 serial ports to only Arm Generic UART / PL011:

https://git.launchpad.net/fwts/tree/src/acpi/dbg2/dbg2.c#n55

BSA 1.0 (and BSA 6.1, which depends on BSA 1.0) are now allowing Both Arm Generic UART/PL011, as well as 16550 as valid standard UARTs. And BBR 1.0 (SBBR) does refer to BSA 1.0.

FWTS should be fixed to not limit the "SBBR" test to only the Arm Generic UART, and allow 16550 as well.

Note that this is not an issue in the FWTS SPCR test, as there is no restriction on the serial port type with the SBBR flag: https://git.launchpad.net/fwts/tree/src/acpi/spcr/spcr.c#n98

samerhaj commented 3 years ago

This issue was opened here by mistake. Closing