ARMmbed / icetea

DEPRECATED mbed test framework
Apache License 2.0
6 stars 7 forks source link

Made pyshark optional. #102

Closed jonikula closed 5 years ago

jonikula commented 5 years ago

Status

READY

Description

Made pyshark and pyshark-legacy optional. They are now only checked when Icetea actually tries to instantiate the Wireshark object. This is a band-aid for https://github.com/ARMmbed/icetea/issues/101

Todos

SeppoTakalo commented 5 years ago

Mbed OS stil uses Icetea 1.2.* release https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt#L21

So this is not going to fix, unless 2.x is compatible.

jonikula commented 5 years ago

I'll create a separate PR to go in that branch.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1229


Changes Missing Coverage Covered Lines Changed/Added Lines %
icetea_lib/wireshark.py 4 6 66.67%
icetea_lib/TestBench/NetworkSniffer.py 0 4 0.0%
<!-- Total: 4 10 40.0% -->
Totals Coverage Status
Change from base Build 1215: -0.04%
Covered Lines: 6173
Relevant Lines: 8009

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1289


Changes Missing Coverage Covered Lines Changed/Added Lines %
icetea_lib/wireshark.py 4 6 66.67%
icetea_lib/TestBench/NetworkSniffer.py 0 4 0.0%
<!-- Total: 4 10 40.0% -->
Totals Coverage Status
Change from base Build 1215: -0.04%
Covered Lines: 6173
Relevant Lines: 8009

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1230


Changes Missing Coverage Covered Lines Changed/Added Lines %
icetea_lib/wireshark.py 4 6 66.67%
icetea_lib/TestBench/NetworkSniffer.py 0 4 0.0%
<!-- Total: 4 10 40.0% -->
Files with Coverage Reduction New Missed Lines %
icetea_lib/wireshark.py 1 67.3%
icetea_lib/TestSuite/TestcaseContainer.py 1 81.61%
icetea_lib/tools/GitTool.py 1 74.7%
icetea_lib/TestSuite/TestSuite.py 1 79.46%
icetea_lib/ResultList.py 1 82.03%
icetea_lib/TestSuite/TestcaseFilter.py 1 90.91%
icetea_lib/Searcher.py 2 93.62%
icetea_lib/AllocationContext.py 2 56.17%
icetea_lib/ResourceProvider/ResourceProvider.py 3 85.37%
icetea_lib/LogManager.py 5 78.24%
<!-- Total: 25 -->
Totals Coverage Status
Change from base Build 1215: -0.1%
Covered Lines: 6166
Relevant Lines: 8010

💛 - Coveralls