Remove hard pyshark dependency on v1.2.1

ARMmbed / icetea

DEPRECATED mbed test framework

Apache License 2.0

6 stars 7 forks source link

Remove hard pyshark dependency on v1.2.1 #103

Closed jonikula closed 5 years ago

jonikula commented 5 years ago

Status

READY

Description

Remove pyshark and pyshark-legacy hard dependency from the older branch of icetea.

Todos

[x] Tests
[x] Documentation

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1250

4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.007%) to 70.506%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
icetea_lib/wireshark.py	4	6	66.67%
<!--	Total:	4	6	66.67%	-->

Totals
Change from base Build 1243:	-0.007%
Covered Lines:	5001
Relevant Lines:	7093

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1249

4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
26 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-0.2%) to 70.355%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
icetea_lib/wireshark.py	4	6	66.67%
<!--	Total:	4	6	66.67%	-->

Files with Coverage Reduction	New Missed Lines	%
icetea_lib/wireshark.py	1	67.3%
icetea_lib/GitTool.py	1	74.7%
icetea_lib/TestSuite/TestSuite.py	1	79.54%
icetea_lib/ResultList.py	1	77.78%
icetea_lib/TestSuite/TestcaseFilter.py	1	82.86%
icetea_lib/Searcher.py	2	93.62%
icetea_lib/AllocationContext.py	2	56.17%
icetea_lib/ResourceProvider/ResourceProvider.py	3	85.54%
icetea_lib/LogManager.py	3	77.65%
icetea_lib/TestSuite/TestcaseContainer.py	4	82.08%
<!--	Total:	26	-->

Totals
Change from base Build 1243:	-0.2%
Covered Lines:	4991
Relevant Lines:	7094

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 1263

4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
25 unchanged lines in 11 files lost coverage.
Overall coverage decreased (-0.2%) to 70.341%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
icetea_lib/wireshark.py	4	6	66.67%
<!--	Total:	4	6	66.67%	-->

Files with Coverage Reduction	New Missed Lines	%
icetea_lib/wireshark.py	1	67.3%
icetea_lib/GitTool.py	1	74.7%
icetea_lib/TestSuite/TestSuite.py	1	79.54%
icetea_lib/ResultList.py	1	77.78%
icetea_lib/TestSuite/TestcaseFilter.py	1	82.86%
icetea_lib/Searcher.py	2	93.62%
icetea_lib/LogManager.py	2	77.27%
icetea_lib/AllocationContext.py	2	56.17%
icetea_lib/ResourceProvider/ResourceProvider.py	3	85.54%
icetea_lib/TestSuite/TestcaseContainer.py	4	82.08%
<!--	Total:	25	-->

Totals
Change from base Build 1243:	-0.2%
Covered Lines:	4990
Relevant Lines:	7094

💛 - Coveralls

SeppoTakalo commented 5 years ago

When will new 1.2.3 be released into PyPi?

jonikula commented 5 years ago

I will tag it and v2.0.1 today, I hope. The root issue should be resolved for us now that the 1.0.4 of trollius is again available though, so this should no longer block you.