Closed jonikula closed 5 years ago
jupe
commented
6 years ago This is a bit better approach than dropping whole feature (#43) - but this is still breaking change in deployment phase. Maybe it's accepted for now but would like to investigate a bit more about root cause why pyshark and psutil should be drop from direct requirements list. at least psutil uses pre-compiled versions by default so should not need compilers either..
jupe
commented
6 years ago I'm pretty sure that we doesn't need this at all since original bug was that pyshark-legacy was installed incorrectly for python 3 even it does not even support python3. #34 fixes pyshark installation and should not cause original problem which was reported here: https://github.com/ARMmbed/mbed-os/issues/8113
coveralls
commented
6 years ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| icetea_lib/wireshark.py | 4 | 6 | 66.67% | ||
| icetea_lib/bench.py | 0 | 20 | 0.0% | ||
| <!-- | Total: | 4 | 26 | 15.38% | --> |
| Totals | |
|---|---|
| Change from base Build 215: | -0.03% |
| Covered Lines: | 4237 |
| Relevant Lines: | 6535 |
coveralls
commented
6 years ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| icetea_lib/wireshark.py | 4 | 6 | 66.67% | ||
| icetea_lib/bench.py | 0 | 20 | 0.0% | ||
| <!-- | Total: | 4 | 26 | 15.38% | --> |
| Totals | |
|---|---|
| Change from base Build 215: | -0.03% |
| Covered Lines: | 4237 |
| Relevant Lines: | 6535 |
jonikula
commented
6 years ago Right, coveralls demands all new lines to be covered.
Status
HOLD
Description
Removed hard dependency on pyshark. Runs should now terminate gracefully if pyshark is missing and --use_sniffer arg is used.