Added skip flash arg - Githubissues

ARMmbed / icetea

DEPRECATED mbed test framework

Apache License 2.0

6 stars 7 forks source link

Added skip flash arg #55

Closed jonikula closed 5 years ago

jonikula commented 5 years ago

Status

READY

Description

Adding argument for skipping flashing. The implementation needs to happen in the allocator plugin, which actually has the flashing and the allocation logic.

Todos

[x] Tests
[x] Documentation

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 356

35 of 35 (100.0%) changed or added relevant lines in 3 files are covered.
10 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.3%) to 69.077%

Files with Coverage Reduction	New Missed Lines	%
icetea_lib/tools/tools.py	1	62.86%
icetea_lib/Events/EventMatcher.py	3	88.57%
icetea_lib/LogManager.py	6	75.97%
<!--	Total:	10	-->

Totals
Change from base Build 331:	0.3%
Covered Lines:	4843
Relevant Lines:	7011

Pull Request Test Coverage Report for Build 452

35 of 35 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 69.863%

Totals
Change from base Build 451:	0.1%
Covered Lines:	4933
Relevant Lines:	7061

💛 - Coveralls

ConradBraam commented 5 years ago

Basic question - I see we have markdown and .RST files, why the duplication?

jonikula commented 5 years ago

At some point there was a request for them so we made them.

ConradBraam commented 5 years ago

It's just an obvious question to ask, about documentation cost; the business and process value is a concern. I'm going to install the tools in development mode soon with all the code insights I am getting, and the ability to try hotfixes. The changes needed, do look very well contained to me, but I'm not an approver.