ARMmbed / icetea

DEPRECATED mbed test framework
Apache License 2.0
6 stars 7 forks source link

Version pinning in *requirements.txt files #69

Closed cmonr closed 5 years ago

cmonr commented 5 years ago

Description

Enhancement

In leiu of recent ARMmbed/mbed-os struggles, I'd strongly suggesting that icetea version pin their python modules, found in these three files:

Reason to enhance/problem with existing solution Version numbers increase CI stability by preventlng a stray module update from halting testing in the repo.

bridadan commented 5 years ago

At least pinning the major version would help with stability quite a bit!

jupe commented 5 years ago

yep, major versio pinning should be enough as long as dependencies follow semantic version rules

jonikula commented 5 years ago

I'll plug this into the next patch.

cmonr commented 5 years ago

as long as dependencies follow semantic version rules

That's always the dream

jonikula commented 5 years ago

PR merged.