search

ARMmbed / icetea

DEPRECATED mbed test framework
Apache License 2.0
6 stars 7 forks source link

Bench refactoring and pylint fixes. #70

Closed jonikula closed 5 years ago

jonikula commented 5 years ago

Status

READY

Description

Refactoring the entire test runner to a more maintainable and testable state.

Todos

Impacted Areas in Application

jupe commented 5 years ago

could you bring pylint also in place for CI stage when tests are green..

jonikula commented 5 years ago

Oh yes, this repo did not enforce it. I'll check.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 583

Changes Missing Coverage Covered Lines Changed/Added Lines %
icetea_lib/Plugin/PluginManager.py 2 3 66.67%
icetea_lib/Plugin/plugins/FileApi.py 2 3 66.67%
icetea_lib/Plugin/plugins/LocalAllocator/DutConsole.py 1 2 50.0%
icetea_lib/Randomize/randomize.py 0 1 0.0%
icetea_lib/ResourceProvider/ResourceConfig.py 2 3 66.67%
icetea_lib/build/build.py 1 2 50.0%
icetea_lib/tools/NodeEndPoint.py 5 6 83.33%
icetea_lib/tools/file/FileUtils.py 2 3 66.67%
icetea_lib/CliAsyncResponse.py 2 4 50.0%
icetea_lib/ResourceProvider/ResourceProvider.py 0 2 0.0%
<!-- Total: 1474 1892 77.91% -->
Files with Coverage Reduction New Missed Lines %
icetea_lib/TestSuite/TestcaseList.py 1 84.92%
icetea_lib/ResourceProvider/ResourceProvider.py 1 89.02%
icetea_lib/ResourceProvider/Allocators/BaseAllocator.py 1 54.55%
icetea_lib/build/build.py 1 82.95%
icetea_lib/TestSuite/TestSuite.py 2 79.6%
icetea_lib/CliResponse.py 2 56.67%
icetea_lib/tools/file/SessionFiles.py 2 92.17%
icetea_lib/tools/tools.py 3 69.29%
icetea_lib/Events/EventMatcher.py 3 88.57%
icetea_lib/TestSuite/TestcaseContainer.py 5 82.79%
<!-- Total: 199 -->
Totals Coverage Status
Change from base Build 527: 3.6%
Covered Lines: 5648
Relevant Lines: 7631
💛 - Coveralls
jonikula commented 5 years ago

@jupe any idea what's exploding in those circle runs? Looks like some environment issue.

jonikula commented 5 years ago

All the other circle runs should now be fixed, except the 3.5 version which is still failing because the image has a really old setuptools version.

jonikula commented 5 years ago

I'm merging this for now, this goes into a separate development branch for collecting version 2 changes so it's not interfering with master. I can start work on other changes that rely on this refactoring once this merge is done.