search

ARPA-SIMC / arkimet

A set of tools to organize, archive and distribute data files.
Other
14 stars 5 forks source link

centos8 needs a newer version of pillow #284

Closed spanezz closed 2 years ago

spanezz commented 2 years ago

Currently arkimet tests fail on centos8 due to PIL not supporting getexif: https://simc.arpae.it/moncic-ci/arkimet/last/master/centos8/build.log

Centos8 seems to have python3-pillow-5.1.1-16.el8.x86_64 where Centos7 has python36-pillow-6.2.2-3.el7.x86_64. I suppose if we want to scan EXIF data with PIL, we need to find a newer version for Centos8

edigiacomo commented 2 years ago

Unfortunately, getexif was introduced in version 6.0.0 https://pillow.readthedocs.io/en/stable/releasenotes/6.0.0.html#added-exif-class. There is a _getexif method, but it's a protected method and it returns a dict instead of an Exif instance.

For now we don't have a rigid deadline to use this functionality in production: until then, we could disable the image scanner support when pillow >= 6.0.0 is unavailable. I hope a RHEL9-based distribution will be available before we have to deploy the image scanner - or we will find another solution.

@brancomat @spanezz what do you think?

brancomat commented 2 years ago

With @edigiacomo we went to pick up the 6.2.2 version from the CentOS7 barrels. We carefully dusted it and move it gently to the CentOS8 cellar. After 2 year of aging is still a bit clear and nowhere as aromatic as the 4-years-old 5.1.1, but with its floral character with a delicate peat note we agreed it's a better match for the subtle intricacies of arkimet.

If our CI agrees (I triggered a rebuild) we can close the issue

brancomat commented 2 years ago

All tests passed.