search

ASFHyP3 / hyp3-testing

BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

refactor _get_tif_tolerances #24

Closed asjohnston-asf closed 3 years ago

asjohnston-asf commented 3 years ago
jhkennedy commented 3 years ago

For the three tests I ran as part of #23 , these tolerances result in:

names = ['hyp3-testing-9Apv1Hj', 'hyp3-testing-evcd52X', 'hyp3-testing-pIcNMBf']

hyp3-testing-9Apv1Hj/main hyp3-testing-9Apv1Hj/develop -- fail
hyp3-testing-evcd52X/main hyp3-testing-pIcNMBf/develop -- pass
hyp3-testing-pIcNMBf/main hyp3-testing-pIcNMBf/develop -- pass

hyp3-testing-9Apv1Hj/main hyp3-testing-evcd52X/main -- fail
hyp3-testing-evcd52X/main hyp3-testing-pIcNMBf/main -- pass
hyp3-testing-pIcNMBf/main hyp3-testing-9Apv1Hj/main -- fail

hyp3-testing-9Apv1Hj/develop hyp3-testing-evcd52X/develop -- fail
hyp3-testing-evcd52X/develop hyp3-testing-pIcNMBf/develop -- pass
hyp3-testing-pIcNMBf/develop hyp3-testing-9Apv1Hj/develop -- fail
jhkennedy commented 3 years ago

Alright, since #23 passes all 9 of the above, I think the "right" (whatever that means) tolerances is somewhere between these two -- I'm going to merge and then slowly move back towards the tolerances in #23 until all the main v main and dev v dev runs pass