AbanteAI / rawdog

Generate and auto-execute Python scripts in the cli
Apache License 2.0
1.79k stars 140 forks source link

Add pyreadline to pyproject.toml #88

Closed jakethekoenig closed 9 months ago

jakethekoenig commented 9 months ago

This project is installed from the pyproject.toml which doesn't reference the requirements.txt. We should probably either dynamically import the requirements.txt or delete it and only store the dependencies in the pyproject.toml. I favor deleting the requirements.txt.

granawkins commented 9 months ago

is that standard? feels like there's always a requirements.txt for a python project?

jakethekoenig commented 9 months ago

is that standard? feels like there's always a requirements.txt for a python project?

Yeah it feels weird to me but I think it is standard when using poetry. I haven't used poetry myself before. Looks like black does it this way. There are ways to dynamically import a requirements.txt into the toml but they look janky and non-standard to me. We certainly don't want the dependencies listed in two places.

granawkins commented 9 months ago

Ok after we discussed I'm on board with requirements.txt