search

AcademySoftwareFoundation / OpenColorIO-Config-ACES

https://opencolorio.org
BSD 3-Clause "New" or "Revised" License
268 stars 38 forks source link

[ENHANCEMENT]: Include HDR Output Transforms in the views list for Display P3 #112

Open nick-shaw opened 1 year ago

nick-shaw commented 1 year ago

Apple kCGColorSpaceExtendedDisplayP3 supports float values above 1.0 for HDR/EDR display on capable Mac systems. Currently the views for the newly added Display P3 display in the Studio and CG configs only include the SDR D65 and D60 sim Output Transforms. The addition of HDR Output transforms to that list would greatly simplify working in HDR for users with suitable Apple devices.

I have previously made my own config which does exactly this, and in my (admittedly limited) testing there appear to be no issues with mixing SDR and HDR views for the same display.

KelSolaar commented 1 year ago

Hey @nick-shaw,

Thanks! The starting point is to have the corresponding Output Transform on the aces-dev side like I did for the SDR variant. Once this is done, we can start looking at adding it to the config.

Cheers,

nick-shaw commented 1 year ago

Thanks @KelSolaar

So is it the case that the config must have a 1:1 relationship with Output Transforms in aces-dev? I was imagining that given the separation of views and displays in OCIO, it would only be necessary to add to the Display P3 views list, to indicate that (on suitable devices) it was capable of showing HDR as well as SDR view transforms. Probably only ACES 1.1 - HDR Video (1000 nits & P3 lim).

KelSolaar commented 1 year ago

Yes, we derive the Reference transforms to build from aces-dev and use a spreadsheet that links a given ACEStransformID to the relevant OCIO BuiltinTransform and Display Colorspace: https://docs.google.com/spreadsheets/d/1SXPt-USy3HlV2G2qAvh9zit6ZCINDOlfKT07yXJdWLg/edit#gid=0

nick-shaw commented 1 year ago

This commit adds Display P3 1000 nit forward and inverse Output Transforms. But it is not clear to me what the file names and transform IDs should be.

Thoughts?

Tagging @scottdyer and @aforsythe.

doug-walker commented 2 months ago

This would require a separate display rather than overloading the existing SDR Display P3. Apple has an extended Display P3 color space, so perhaps that could inform the name. It needs to be clear whether a display is either an SDR or HDR target.