Changed port instruction format in docker-compose file according to the latest format

Accenture / adop-docker-compose

Talk to us on Gitter: https://gitter.im/Accenture/ADOP

https://accenture.github.io/adop-docker-compose

Apache License 2.0

764 stars 573 forks source link

Changed port instruction format in docker-compose file according to the latest format #241

Closed svscorp closed 7 years ago

svscorp commented 7 years ago

Hi team,

This is an important change that is blocking adop installation using existing docker-compose.yml on a server or Swarm API where docker-compose is v1.13+

Can it be merged to master?

@nickdgriffin @SachinKSingh28

nickdgriffin commented 7 years ago

Hi Ilia,

This is a duplication of https://github.com/Accenture/adop-docker-compose/pull/229 so my comment still stands - has this been tested against the version of Docker Compose stated in our pre-requisites as the version we are compatible with?

Thanks, Nick

arthur-kovalenko commented 7 years ago

@nickdgriffin I tested this PR with Docker 1.10/1.12/1.13/17.06 and Docker compose v1.9.0, and it is working

svscorp commented 7 years ago

Thanks @arthur-kovalenko ! Was on vacation with no chance to test this.

nickdgriffin commented 7 years ago

Cool thanks @arthur-kovalenko , I'll merge then.