Nexus upgrade to latest adop version

marisbahtins commented 6 years ago

Added required parameters for new Nexus image.

dsingh07 commented 6 years ago

Dependent Nexus PR merged and release created: https://github.com/Accenture/adop-nexus/releases/tag/0.2.1
Upgrade path defined: https://github.com/Accenture/adop-nexus/wiki/Nexus:-Upgrade-Process-from-version-2.x-to-3.7.1

LGTM from my side, @RobertNorthard can you test/review please?

RobertNorthard commented 6 years ago

Hi @marisbahtins / @dsingh07

I reviewed on a fresh stack and I am unable to login.

The following exception is in the log:


java.lang.RuntimeException: Error grabbing Grapes -- [download failed: org.apache.james#apache-mime4j;0.6!apache-mime4j.jar, download failed: com.sun.xml.fastinfoset#FastInfoset;1.2.12!FastInfoset.jar, download failed: com.fasterxml.jackson.core#jackson-core;2.8.6!jackson-core.jar, download failed: com.fasterxml.jackson.core#jackson-databind;2.8.6!jackson-databind.jar]
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
        at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:83)
        at org.codehaus.groovy.reflection.CachedConstructor.doConstructorInvoke(CachedConstructor.java:77)
        at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrap.callConstructor(ConstructorSite.java:84)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallConstructor(CallSiteArray.java:59)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:238)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callConstructor(AbstractCallSite.java:250)
        at groovy.grape.GrapeIvy.getDependencies(GrapeIvy.groovy:422)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite$PogoCachedMethodSite.invoke(PogoMetaMethodSite.java:169)
        at org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite.callCurrent(PogoMetaMethodSite.java:59)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:157)
        at groovy.grape.GrapeIvy.resolve(GrapeIvy.groovy:569)
        at groovy.grape.GrapeIvy$resolve$1.callCurrent(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:157)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:193)
        at groovy.grape.GrapeIvy.resolve(GrapeIvy.groovy:536)
        at groovy.grape.GrapeIvy$resolve$0.callCurrent(Unknown Source)
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:157)
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:185)
        at groovy.grape.GrapeIvy.grab(GrapeIvy.groovy:254)
        at groovy.grape.Grape.grab(Grape.java:167)
        at groovy.grape.GrabAnnotationTransformation.visit(GrabAnnotationTransformation.java:376)
        at org.codehaus.groovy.transform.ASTTransformationVisitor$3.call(ASTTransformationVisitor.java:346)
        at org.codehaus.groovy.control.CompilationUnit.applyToSourceUnits(CompilationUnit.java:966)
        at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation(CompilationUnit.java:626)
        at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:602)
        at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:579)
        at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:323)
        at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:293)
        at groovy.lang.GroovyShell.parseClass(GroovyShell.java:677)
        at groovy.lang.GroovyShell.run(GroovyShell.java:506)
        at groovy.lang.GroovyShell.run(GroovyShell.java:496)
        at groovy.ui.GroovyMain.processOnce(GroovyMain.java:597)
        at groovy.ui.GroovyMain.run(GroovyMain.java:329)
        at groovy.ui.GroovyMain.process(GroovyMain.java:315)
        at groovy.ui.GroovyMain.processArgs(GroovyMain.java:134)
        at groovy.ui.GroovyMain.main(GroovyMain.java:114)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.codehaus.groovy.tools.GroovyStarter.rootLoader(GroovyStarter.java:116)
        at org.codehaus.groovy.tools.GroovyStarter.main(GroovyStarter.java:138)

1 error

Maybe all the dependencies should be backed into the image. Also, some environments do not have outbound internet.

dsingh07 commented 6 years ago

This is now fixed by @marisbahtins in https://github.com/Accenture/adop-nexus/pull/14 by pre-downloading all the dependencies.

Have cut a new release with that PR merged in: https://github.com/Accenture/adop-nexus/releases/tag/0.2.2

@marisbahtins can you please rebase and update your PR to drop in the 0.2.2 tag?
@RobertNorthard can you test with the 0.2.2 tag please?

RobertNorthard commented 6 years ago

Thanks @dsingh07 and thank you @marisbahtins

Test cases performed:

[x] ADOP Docker Compose platform loads without issues
[x] Nexus Authenticates with LDAP / Basic Authentication through ADOP proxy.
[x] Tested uploading JAR file to a new hosted repository using mvn deploy-file.

The only defect is that the Nexus sign-out link does not log the currently authenticated principle out. This is because the proxy will log you back in as Basic authentication is off-loaded to the proxy.

Accenture / adop-docker-compose

Nexus upgrade to latest adop version #272