AdalynBlack / LipsyncHelper

GNU General Public License v2.0
6 stars 0 forks source link

NullReferenceException: Object reference not set to an instance of an object #2

Closed ChipTheProto closed 1 month ago

ChipTheProto commented 6 months ago

With the Unity 2022 Editor update I get:

NullReferenceException: Object reference not set to an instance of an object LipsyncToAnim.Convert () (at Assets/LipsyncToAnim/LipsyncToAnim.cs:83) LipsyncToAnim.OnValidate () (at Assets/LipsyncToAnim/LipsyncToAnim.cs:53) UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

after clicking convert. Used it a bunch on 2019 with no problems.

AdalynBlack commented 6 months ago

It looks like Oculus's OVR Lipsync package may have been updated I'll have a look at it and try to update it

ChipTheProto commented 6 months ago

Weird cause I used the same package for it that I downloaded a year ago when I found this wonderful plugin.

ChipTheProto commented 3 months ago

Any luck on this?

Mirasaru commented 1 month ago

I would also like to know if there is any news on this. the asset doesnt work on 2022 and the 2019 unity for vrchat has been obsolete

ChipTheProto commented 1 month ago

I would also like to know if there is any news on this. the asset doesnt work on 2022 and the 2019 unity for vrchat has been obsolete

What I've been doing in the meantime is pulling the model into an old project and running the script then moving the anim file back to the newer one for upload.

AdalynBlack commented 1 month ago

So sorry I haven't worked on this for a while. I've been busy with school and such for a while now, but I should be free to fix the problem now. It might be a day or two before I get a chance to take a look, but I'll definitely have a look when I have a chance

AdalynBlack commented 1 month ago

I'm trying to recreate the issue on my end and it seems to work just fine. Could you verify the issue with a fresh project and installation, using the latest version of the OVRLipSync package? The core of the issue seems to be related to OVRLipSync failing to generate any lipsync data for the input audio from what I can tell

Mirasaru commented 1 month ago

the issue is the exact same as what was posted in december, NullReferenceException: Object reference not set to an instance of an object. i installed the latest version of ovrlipsync but so far nothing

AdalynBlack commented 1 month ago

I see could you try the demo scene, and if that fails, could you try cloning the git repo and upgrading it to Unity 2022?

ChipTheProto commented 1 month ago

the issue is the exact same as what was posted in december, NullReferenceException: Object reference not set to an instance of an object. i installed the latest version of ovrlipsync but so far nothing

Same. Tested in 2022.3.22f.

ChipTheProto commented 1 month ago

I see could you try the demo scene, and if that fails, could you try cloning the git repo and upgrading it to Unity 2022?

Demo scene succeeds but continues to fail with any other avatar.

AdalynBlack commented 1 month ago

I see could you send me the audio clip that's causing issues?

ChipTheProto commented 1 month ago

I used the audio clip included in the demo for the latest test but this error was on me for having the script in the wrong place. It converts with the provided sample audio but when the audio is changed to any other clip, back to the old error.

AdalynBlack commented 1 month ago

ohh I found the issue Enable "Preload Audio Data" on the audio file. Newer Unity versions seem to import with that disabled by default. I'll push a fix that loads the data if it's not already loaded

ChipTheProto commented 1 month ago

Can confirm, that was it! Yay, glad it wasn't anything major.

AdalynBlack commented 1 month ago

Ok, this issue is now officially resolved. As of Version 0.2.3, the script will now load the audio if it isn't already loaded