AdamPS / rrssb-plus

Ridiculously Responsive Social Sharing Buttons Plus
http://www.albanyweb.co.uk/rrssb-plus
MIT License
15 stars 6 forks source link

Added new X/twitter icon. #14

Closed sourabh-vb closed 6 months ago

AdamPS commented 6 months ago

Thanks please can you make it match the others?

AdamPS commented 6 months ago

Thanks however you need to scale all the co-ordinates also to fit in the new viewbox😃. Hopefully your SVG editing tool can do it automatically. Then also do the second bullet to remove some parts from the minimised one.

sourabh-vb commented 6 months ago

@AdamPS Could you please check it now.

AdamPS commented 6 months ago

Great, that's better. I think we can safely cut it to 1 (or max 2) decimal places, then I will commit.

sourabh-vb commented 6 months ago

Do you want us to change value in decimal inside viewbox or the values in path tag should contains only 1 or 2 decimal digit?

AdamPS commented 6 months ago

Values in path tag please.

We can save a few bytes and it should look exactly the same to the eye.

sourabh-vb commented 6 months ago

Thanks @AdamPS . Please review it now.

AdamPS commented 6 months ago

OK but now missing and again it needs to be just one line please.

I think we don't need x="0px" y="0px"

sourabh-vb commented 6 months ago

Updated it @AdamPS . Let me know if you need more changes.

AdamPS commented 6 months ago

Great thanks.

sourabh-vb commented 6 months ago

@AdamPS Apologies! I missed a change in which Both files contains the blankline and End of file so we need to remove that too. So can we create a new fork and create a PR for that?

AdamPS commented 6 months ago

OK I just fixed X.min.svg and I also removed some zeros. The other file can have a blank line, it's fine.

sourabh-vb commented 6 months ago

Thanks @AdamPS . Really appreciated