search

AdamPS / rrssb-plus

Ridiculously Responsive Social Sharing Buttons Plus
http://www.albanyweb.co.uk/rrssb-plus
MIT License
15 stars 6 forks source link

Icons overlapping #3

Closed joewhitsitt closed 6 years ago

joewhitsitt commented 6 years ago

Using the demo page https://www.albanyweb.co.uk/rrssb-plus I altered the configuration to use values the script prefers (undocumented otherwise), and the icons are overlapping.

screen shot 2017-11-28 at 11 58 00 am

screen shot 2017-11-28 at 11 58 20 am

screen shot 2017-11-28 at 11 58 44 am

Thinking I did my "worst" as suggested, I just tried to hide the prefix (reserved width = 0, max width = 0.1) and I got this: screen shot 2017-11-28 at 12 01 27 pm

Any insight how how to get this to work would be much appreciated.

AdamPS commented 6 years ago

Thanks for the report. I have fixed a bug on the demo system (i.e. not a problem in the actual library code). Please can you try again - I think it is working better now.

I spotted a second bug in the demo system - the "right-align buttons" box will break the buttons so please don't use it on the demo. The library JS doesn't have code to handle the alignment changing without a page refresh. Again this is a demo-only problem - on a real site, the alignment won't change without a page refresh.

joewhitsitt commented 6 years ago

Fair enough. Using the same config as above, I got these results:

screen shot 2017-11-28 at 1 43 18 pm

and hide the prefix only config (reserved width = 0, max width = 0.1): screen shot 2017-11-28 at 1 47 18 pm

AdamPS commented 6 years ago

I have just fixed another bug that I spotted with those specific settings: #4

AdamPS commented 6 years ago

And the right-align is now working in the demo