Remove explicit override to prevent build issues with newer CEF

Adamcake / Bolt

An alternative launcher for your favourite MMO

GNU Affero General Public License v3.0

122 stars 18 forks source link

Closed Jertzukka closed 5 months ago

Jertzukka commented 5 months ago

As of https://github.com/chromiumembedded/cef/commit/ef6ae3071d065455aa21105a9449dd333878aa8d (Sep 14, 2023) override on ChromeToolbarType GetChromeToolbarType() will error out as its definition has changed. There's few options:

This PR: remove explicit override to keep backwards compatibility with older CEF like 114 binary currently provided by you, or
Keep override, update definition to GetChromeToolbarType(CefRefPtr<CefBrowserView> browser_view) and build against newer CEF.

Adamcake commented 5 months ago

This function isn't even getting called since we aren't using the Chrome runtime so I think we can just remove the override.