search

Adamcake / Bolt

An alternative launcher for your favourite MMO
GNU Affero General Public License v3.0
186 stars 26 forks source link

(Suggestion) Is it possible to open login window in normal browser, rather than CEF? #77

Open allisonkong opened 4 weeks ago

allisonkong commented 4 weeks ago

Basically the title. In AuthService we open the login window here:

https://github.com/Adamcake/Bolt/blob/master/app/src/lib/Services/AuthService.ts#L51

but I'm curious if it would be possible to open this in the standard browser instead?

Two benefits to this:

  1. Convenience - I use a password manager and it can autofill in my normal browser but not CEF.
  2. Very slight security benefit - I feel better if I can be extra sure I'm not getting phished, since my password manager will not autofill if the domain is incorrect. Granted it's not a huge benefit since running Bolt in the first place implies a lot of trust that it's not compromised somehow, but it would still be a small nice to have.
Adamcake commented 4 weeks ago

Not via Bolt. The main issue is that the login flow redirects to localhost:80 so I'd have to bind to port 80, which on Linux generally requires root permissions. With CEF we can handle that with an internal redirect without having to bind to any ports.

There was a command-line project which apparently got external browser login working:

https://github.com/chowder/golt

but requires a bit of setup.