Complete list of 17 error reports on login

[Kream]

Addon Version

1.9.46

World of Warcraft Version

Retail

Describe the bug

When logging in, the following are the error reports generated:

BUG 01
1x Interface/AddOns/AdiBags/core/Core.lua:185: attempt to index field 'anchor' (a nil value)
[string "@Interface/AddOns/AdiBags/core/Core.lua"]:185: in function <Interface/AddOns/AdiBags/core/Core.lua:184>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:558: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:551>
[string "=(tail call)"]: ?
[string "@Interface/AddOns/CallbackHandler-1.0-7/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:119: in function <...dler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:119>
[string "=[C]"]: ?
[string "@Interface/AddOns/CallbackHandler-1.0-7/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:29: in function <...dler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@Interface/AddOns/CallbackHandler-1.0-7/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:64: in function <...dler-1.0/CallbackHandler-1.0/CallbackHandler-1.0.lua:59>
[string "=(tail call)"]: ?

BUG 02
1x Interface/AddOns/AdiBags/core/Utility.lua:334: Usage: GetItemSubClassInfo(itemClassID, itemSubClassID)
[string "=[C]"]: in function `GetItemSubClassInfo'
[string "@Interface/AddOns/AdiBags/core/Utility.lua"]:334: in main chunk

Locals:
(*temporary) = nil
(*temporary) = 0

BUG 03
1x Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:783: Usage: GetItemClassInfo(itemClassID)
[string "=[C]"]: in function `GetItemClassInfo'
[string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:783: in main chunk

Locals:
(*temporary) = nil

BUG 04
1x Interface/AddOns/AdiBags/modules/FilterOverride.lua:57: Usage: GetItemSubClassInfo(itemClassID, itemSubClassID)
[string "=[C]"]: in function `GetItemSubClassInfo'
[string "@Interface/AddOns/AdiBags/modules/FilterOverride.lua"]:57: in main chunk

Locals:
(*temporary) = nil
(*temporary) = 0

BUG 05
1x Interface/AddOns/AdiBags/modules/Junk.lua:50: Usage: GetItemSubClassInfo(itemClassID, itemSubClassID)
[string "=[C]"]: in function `GetItemSubClassInfo'
[string "@Interface/AddOns/AdiBags/modules/Junk.lua"]:50: in main chunk

Locals:
(*temporary) = nil
(*temporary) = 0

BUG 06
1x Interface/AddOns/AdiBags/core/DefaultFilters.lua:44: Usage: GetItemClassInfo(itemClassID)
[string "=[C]"]: in function `GetItemClassInfo'
[string "@Interface/AddOns/AdiBags/core/DefaultFilters.lua"]:44: in function `SetupDefaultFilters'
[string "@Interface/AddOns/AdiBags/core/Filters.lua"]:65: in function `InitializeFilters'
[string "@Interface/AddOns/AdiBags/core/Core.lua"]:97: in function <Interface/AddOns/AdiBags/core/Core.lua:81>
[string "=[C]"]: ?
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:494: in function `InitializeAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:619: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

BUG 07
1x Interface/AddOns/AdiBags/core/Layout.lua:128: attempt to index field 'anchor' (a nil value)
[string "@Interface/AddOns/AdiBags/core/Layout.lua"]:128: in function `UpdatePositionMode'
[string "@Interface/AddOns/AdiBags/core/Core.lua"]:179: in function <Interface/AddOns/AdiBags/core/Core.lua:122>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

BUG 08
1x Interface/AddOns/AdiBags/modules/TooltipInfo.lua:55: GameTooltip doesn't have a "OnTooltipSetItem" script
[string "=[C]"]: in function `HookScript'
[string "@Interface/AddOns/AdiBags/modules/TooltipInfo.lua"]:55: in function <Interface/AddOns/AdiBags/modules/TooltipInfo.lua:53>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:536: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

BUG 09
1x Interface/AddOns/AdiBags/core/Utility.lua:1 (null)

BUG 10
1x Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1 (null)

BUG 11
1x Interface/AddOns/AdiBags/modules/FilterOverride.lua:1 (null)

BUG 12
1x Interface/AddOns/AdiBags/modules/Junk.lua:1 (null)

BUG 13
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/core/Utility.lua:1 (null)

BUG 14
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:1 (null)

BUG 15
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/modules/FilterOverride.lua:1 (null)

BUG 16
1x FrameXML\Bindings.xml:1 Interface/AddOns/AdiBags/modules/Junk.lua:1 (null)

BUG 17
2x Interface/AddOns/AdiBags/modules/DataSource.lua:123: attempt to call upvalue 'GetContainerNumSlots' (a nil value)
[string "@Interface/AddOns/AdiBags/modules/DataSource.lua"]:123: in function <Interface/AddOns/AdiBags/modules/DataSource.lua:119>
[string "@Interface/AddOns/AdiBags/modules/DataSource.lua"]:152: in function `Update'
[string "@Interface/AddOns/AdiBags/modules/DataSource.lua"]:78: in function <Interface/AddOns/AdiBags/modules/DataSource.lua:70>
[string "=[C]"]: ?
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:66: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:61>
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:523: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:536: in function `EnableAddon'
[string "@Interface/AddOns/AdiBags/libs/AceAddon-3.0-13/AceAddon-3.0.lua"]:626: in function <...ce/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:611>

Steps to reproduce

Log in with Adibags enabled.

Verification

• [X] I have disabled all other addons and made sure this bug is triggered only with AdiBags enabled

[zaldor30]

Yeah list seems pretty complete to me.

[glassleo]

I'm sure @Cidan is aware, have some patience...

[zaldor30]

Yes, I know that was adding a confirmation not a rush on it. Nothing implied that at all.

[MleveK]

I've Repaired most of the issues. There might still be problems, let me know and I can look into it. First, make sure it's not an addon interfering. I had to remove a few functionalities. AdiBagsV2.zip

[zaldor30]

Seems good so far, no more errors and seems to be working

[zaldor30]

Think you left a debug print statement in it though

[MleveK]

Download V2 I just posted and fixed that (Edited in the previous post so V1 isn't downloaded by mistake)

[zaldor30]

Cool thanks

[cindynico]

OMG ty, the only thing i could see was a line with the currencies, my bags are back now ty

[ozgod1]

I downloaded V2 and it's working now, thanks for updating it. The only issue I can find is that when you use a consumable (e.g. enchantment scroll, food, flask, soul ash/soul cinder) by right clicking on it from the Adibags view it does not reduce the quantity until you close and reopen the bag.

[Werneq]

I downloaded V2 and it's working now, thanks for updating it. The only issue I can find is that when you use a consumable (e.g. enchantment scroll, food, flask, soul ash/soul cinder) by right clicking on it from the Adibags view it does not reduce the quantity until you close and reopen the bag.

For me when using any consumable or equip anything it closes the bag window. No errors occur thought.

[juntereiner]

@MleveK Thank you for the update. The biggest issue I have is when I use the option "Merge stackables items including incompletes stacks", the stack size number is wrong for any items.

[karpana]

Thank you for the update! Much appreciated.

[BourgeoisM]

Thx for the Fix it works perfectly fine!

Way more stable than the things i was trying to do !

[rodalpho]

MleveK, thanks so much! You are a prince amongst men, or a princess amongst women, or a dracthyr thing amongst drakonids.

[MleveK]

V3 I don't mind updating this, It's one of my favorite addons, I had it off because of the errors and couldn't find a piece of gear in my bags for 10 minutes, I got frustrated and decided to see if I could temporarily fix it anyways.

@ozgod1 - I fixed Using a consumable, the window should now update. @juntereiner - I fixed Stackable including incomplete stacks not showing the correct count.

@Werneq - I'm not sure why the window closes when you click on something. I don't have that issue. Try with just this addon(disable all others), and if it persists, I'm assuming it's an option somewhere that I'm not using that's triggering it. Try switching to the default profile and see if it resolves it. if you can pinpoint the option causing this, I don't mind taking a look at it.

Note: I did notice that when moving an item the border color doesn't update correctly. Not crucial but if I have time I'll take a look. If more issues come up that are critical, let me know.

I'm sorry if some of the errors are missed, I'm not trying to make the addon back to 100%, just workable for now.

AdiBagsV3.zip

[MechaZao]

much appreciated for the bandaid version! at this point I'm mostly having trouble with pretty much ALL of the third party adibags modules i have downloaded lol

I hope there will eventually be a fix for all these SetBagItem errors and that the old (perhaps abandoned) ones can be repaired too

[Werneq]

No worries, you are doing a great job. I'll try a fresh interface folder when I can and update here after. TYSM for your work, we love adibags

[Bronski]

Just FYI: With the v3 fix, the count of free slots seems missing, and the search box doesn't highlight.

Thanks for updating it.

[Frurox]

When will v3 be in CurseForge?

[Darkeclipsee]

Hi, sorry for asking but I'm not used to manually updating my addons. Is there any change it'll be updated on curseforge soon?

[Cidan]

Hi everyone, official maintainer here.

Unfortunately, I am out of town on a work trip on the exact week that this new patch hit :|

Blizzard decided to make sweeping bag API changes in this patch version, but did not provide early-access to all addon authors, making it all-but-certain bag addons would break upon release of this patch. As soon as I'm back home Sunday night PST, I will start working on an official fix for AdiBags.

I'm very, very sorry to all our users that AdiBags is broken this week, and I take full responsibility here. Sadly, my work trip was unavoidable. Expect a full update next week.

Thanks!

[Frurox]

Hi everyone, official maintainer here.

Unfortunately, I am out of town on a work trip on the exact week that this new patch hit :|

Blizzard decided to make sweeping bag API changes in this patch version, but did not provide early-access to all addon authors, making it all-but-certain bag addons would break upon release of this patch. As soon as I'm back home Sunday night PST, I will start working on an official fix for AdiBags.

I'm very, very sorry to all our users that AdiBags is broken this week, and I take full responsibility here. Sadly, my work trip was unavoidable. Expect a full update next week.

Thanks!

RL takes precedence, Thank you for a great Addon that gave Blizzard the idea to make their own, your is still superior!

[ozgod1]

@MleveK thank you for your efforts, it's certainly workable. The issues are just minor things that don't prevent usage, but I thought to have them reported. Appreciate your work.

@Cidan thank you for your efforts in maintaining the best bag addon in WoW!

[Cidan]

I also want to thank @MleveK for their work in my absence -- I am incredibly grateful for your efforts. Thank you!

On Wed, Nov 16, 2022, 19:10 ozgod1 @.***> wrote:

@MleveK https://github.com/MleveK thank you for your efforts, it's certainly workable. The issues are just minor things that don't prevent usage, but I thought to have them reported. Appreciate your work.

@Cidan https://github.com/Cidan thank you for your efforts in maintaining the best bag addon in WoW!

— Reply to this email directly, view it on GitHub https://github.com/AdiAddons/AdiBags/issues/782#issuecomment-1317999623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIUYPHQEJYPIJS2UJUJK7DWIWO3BANCNFSM6AAAAAASB7ZC6U . You are receiving this because you were mentioned.Message ID: @.***>

[glassleo]

Thanks for the quick fix, now I can at least play the game while waiting for the update! <3

[set4812]

@MleveK can you create a pull request for your changes? @Cidan I know you are absent, but can you speed up doing the code review for @MleveK when he creates PR?

[Kream]

@set4812 please chill out. Make do with @MleveK 's zip file like the rest of us until Cidan has time.

[set4812]

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

[Werneq]

@MleveK Very strange, I tried with only adibags and the window still closes, after fiddling on configs and reload a couple times it stop. I have zero problems right now.

Sorry I could not find the source of this bug, if I find it again I'll update here. For now thanks for the help.

[SpareSimian]

Two more to fix: UseContainerItem in Junk.lua and BankSwitcher.lua is now in C_Container.

[Wraiven]

yay ty @MleveK for a quick fix till Cidan gets back.

@Cidan do you plan on adding the slot for the new reagent bag? As of now no way to access that slot or open it

[travisneids]

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

@set4812 You realize that this is not @Cidan's job? He does this for free for the community? This demand is disgusting.

[joshbowman]

I'm glad I looked in here. Thanks for the quick patch @MleveK , and thanks for the wonderful work on this addon in general @Cidan. Being thrown back into the default bag UI and staring at a giant wall of items I can't make visual sense of has renewed my appreciation for everything this addon does for me.

[MleveK]

I'm working on some more fixes, I noticed a few errors with the Bank (@SpareSimian mentioned), and the Free Slots not showing the actual count and I'll see what I can do with the Reagent Bag spot(No guarantees lol). Will post a new version later today.

I'll also see what I can do for Git but in the end, that's @Cidan to decide.

Also @Cidan You're more than welcome to use my code to get you moving forward when you have a chance to update it all. It's not perfect but should save you some time. You can always reach out if you need anything from me.

[kaarosu]

I'm working on some more fixes, I noticed a few errors with the Bank (@SpareSimian mentioned), and the Free Slots not showing the actual count and I'll see what I can do with the Reagent Bag spot(No guarantees lol). Will post a new version later today.

I'll also see what I can do for Git but in the end, that's @Cidan to decide.

Also @Cidan You're more than welcome to use my code to get you moving forward when you have a chance to update it all. It's not perfect but should save you some time. You can always reach out if you need anything from me.

Just wanted to say thanks for the quick fix until the author comes back! Only things that really needed updating to your V3 were:

-- Container constants
ITEM_INVENTORY_BANK_BAG_OFFSET  = 4; -- Number of bags before the first bank bag
CONTAINER_BAG_OFFSET = 30; -- Used for PutItemInBag

BACKPACK_CONTAINER = Enum.BagIndex.Backpack;
BANK_CONTAINER = Enum.BagIndex.Bank;
BANK_CONTAINER_INVENTORY_OFFSET = 39; -- Used for PickupInventoryItem
REAGENTBANK_CONTAINER = Enum.BagIndex.Reagentbank;

NUM_BAG_SLOTS = Constants.InventoryConstants.NumBagSlots;
NUM_REAGENTBAG_SLOTS = Constants.InventoryConstants.NumReagentBagSlots;
NUM_TOTAL_EQUIPPED_BAG_SLOTS = NUM_BAG_SLOTS + NUM_REAGENTBAG_SLOTS;
NUM_BANKGENERIC_SLOTS = Constants.InventoryConstants.NumGenericBankSlots;
NUM_BANKBAGSLOTS = Constants.InventoryConstants.NumBankBagSlots;

Edit: Also a UseContainerItem = C_Container.UseContainerItem

[set4812]

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

@set4812 You realize that this is not @Cidan's job? He does this for free for the community? This demand is disgusting.

I don't know if you read my first statement and understood it. @Cidan is the maintainer, he can only merge changes, but he is absent until the end of the week. I understand his absent and that he can't spend time on addon fixes. @MleveK is doing a great job at the moment, but you get patches in the form of a ZIP, which is not an official build. That's why I suggested a pull request for MleveK to do, then @Cidan can read the code in his free time and click merge. It will reduce the time his job on the project I didn't force anyone to do it.

[kalvin807]

@Cidan @MleveK I opened PR #786 which addresses errors since the 10.0.2 update. Will be helpful if you can review it

[Cidan]

I appreciate the passion here everyone -- really, it's great to be a part of something that so many people find so useful. While I do understand the desire to see an official fix come out the door, I can't reasonably test or review changes in any meaningful way while I'm traveling. Specifically, all changes need to work across all product lines for WoW, i.e. retail, wrath, classic, etc, and I have no way to verify all the weird corner cases work before putting out a release.

Please feel free to keep creating patches, PR's, and suggesting changes, as they are most welcome, however nothing will be merged until I am back in front of my gaming rig at the end of the weekend.

Thank you everyone!

[SpareSimian]

The bag-sorting methods are now in the C_Container namespace. There are about a half dozen spots affected. Look for "Sort.*Bags" (that's a regex).

[Cidan]

The bag-sorting methods are now in the C_Container namespace. There are about a half dozen spots affected. Look for "Sort.*Bags" (that's a regex).

It's slightly more complicated than that, as

1) We need to account for this change only in retail 2) Some of the return values have also changed (i.e. tables instead of multiple value returns)

My current line of thought (I haven't looked at the PR's) is to just redefine the globals with functions that unpack tables using the new API. This minimizes the amount of code locations that need to change. There are also some other fixes in general I have sitting in a branch, i.e. the undocumented bank offset change, reagent bag, etc, that need to be applied.

[SpareSimian]

Ok, that makes sense. Patching in C_Container for the sorting methods lets me continue using the addon in Retail. I can imagine hat a pain it will be if the Wrath engine doesn't use the same namespacing changes. You have my sympathy! Indirection through an adapter function does sound like the best solution.

[BourgeoisM]

The bag-sorting methods are now in the C_Container namespace. There are about a half dozen spots affected. Look for "Sort.*Bags" (that's a regex).

It's slightly more complicated than that, as

1. We need to account for this change only in retail
2. Some of the return values have also changed (i.e. tables instead of multiple value returns)

My current line of thought (I haven't looked at the PR's) is to just redefine the globals with functions that unpack tables using the new API. This minimizes the amount of code locations that need to change. There are also some other fixes in general I have sitting in a branch, i.e. the undocumented bank offset change, reagent bag, etc, that need to be applied.

I kind of tried to do that ..... but i'm not really confident in my lua skills as i'm originally C developper :)

[Frurox]

@Kream but not all community know how to use GitHub and find fixed zip, for most people the current status of the project is not working

Then they will have to learn, like it was 15+ years ago

[MleveK]

Hey All, see attached V4.

• Fixed Free Slot Count
• Added Reagent Bag Slot.
• Added Separate Free Space for Reagent.
• Bank bag fixes
• Converted most of the changes to work for Classic+Wrath. (Not fully tested)

I will submit a PR tomorrow and will link it here for future pushes. Enjoy!!

AdiBagsV4.zip

[grimmtooth]

@MleveK thanks bunches for your good work. It's nice having my bag all sorted again 👍

[Jokinen86]

@MleveK Thank you so much for this. I just wanted to note that v4 appears to have a conflict with Pawn. Any time I opened my bags, I got this:

50x Interface/AddOns/Pawn/Pawn.lua:422: attempt to call global 'GetContainerItemInfo' (a nil value) [string "@Interface/AddOns/Pawn/Pawn.lua"]:422: in function PawnIsContainerItemAnUpgrade' [string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:417: in functionUpdateUpgradeIcon' [string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:345: in function Update' [string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:317: in functionFullUpdate' [string "@Interface/AddOns/AdiBags/widgets/ItemButton.lua"]:281: in function <Interface/AddOns/AdiBags/widgets/ItemButton.lua:269> string "=[C]": in function Show' [string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:1066: in functionPrepareSections' [string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:1187: in function `FullUpdate' [string "@Interface/AddOns/AdiBags/widgets/ContainerFrame.lua"]:619: in function <Interface/AddOns/AdiBags/widgets/ContainerFrame.lua:605>

[string "@Interface/AddOns/AdiBags/core/Utility.lua"]:100: in function <Interface/AddOns/AdiBags/core/Utility.lua:92> [string "@Interface/AddOns/AdiBags/widgets/LayeredRegion.lua"]:119: in function <Interface/AddOns/AdiBags/widgets/LayeredRegion.lua:108>

Locals: bagID = 2 slot = 1 (temporary) = nil (temporary) = 2 (temporary) = 1 (temporary) = "attempt to call global 'GetContainerItemInfo' (a nil value)"

I've disabled Pawn and it's working perfectly now.

[MleveK]

@Jokinen86 Pawn just did an update. I had initially turned off the feature but figured it would be fixed by now so turned it on in V4. If there's still an issue I'll check it tomorrow.

[Wevah]

It seems to be working OK with the latest Pawn (from ≈2 hours ago) for me (no errors at least), except either AdiBags or Pawn spam my chat pane with a ton of nil, nil when I open my bags if both are enabled.

[chilblane]

someone leave a print() somewhere?