Closed iMartzen closed 4 years ago
Hi @iMartzen!
First I apologize it took me so long to give you any feedback, but I was really busy IRL :)
Regardless, code changes look good. I've added some ToDo items of my own how to improve some things (unrelated to your code).
I ran changes on Ubuntu 19.04 with Ansible 2.7.8, deployed to AWS (Ubuntu 18.04) along with changes you made on ansible-role-system-upgrade and everything went great. But one thing is preventing me from merging the changes is that even with updated DNS I'm not be able to access the URL at the end of playbook.
I had same results with 2 brand new AWS instances.
When I SSH to the instance I see all the containers are running as expected. Hence, I'll need to look into a bit deeper to understand what exactly is the problem.
Hello @iMartzen,
I've decided to merge this PR as it does everything is meant to.
In meantime, I've made a major revamp of docker-compose
file. I've also made a switch from MariaDB to MySQL, and removed php-fpm, so routing from Nginx (Let's Encrypt) goes directly to WordPress with Apache working on its "backend".
When I make these changes, I'll do my best to keep you informed in case you need to make any adjustments to your centos related roles.
Thank you for your contribution!
Hello Adnan,
I have completed an update where it is also possible to upgrade for CentOS. I forked your roles and made them fit for distro CentOS. I tested both distros and it is working.
Please review my PR and give some feedback!
Best regards, Martzen