AdrianBZG / InterMine-Data-Browser-Tool

InterMine Data Browser: a tool for exploring semi-homogeneous biological datasets
http://data-browser.apps.intermine.org/
Other
4 stars 38 forks source link

Add chromosome located on to the Locations #46

Closed AdrianBZG closed 6 years ago

AdrianBZG commented 6 years ago

Add chromosome located on to Locations filter

Name it as "Chromosome"

AdrianBZG commented 6 years ago

Done in c9a768e 👍

locatedonlocationfilter

yochannah commented 6 years ago

I can get this to work using the example in the screenshot above - nice one!

Question for @rachellyne: when I try to copy regions from the region search in humanmine to search for in this tool I end up getting no results. After some investigation I realised the query is very precise, and you have to know the exact end and start coordinates -

<query model="genomic" view="Gene.symbol Gene.name Gene.primaryIdentifier Gene.secondaryIdentifier Gene.length Gene.organism.name" >
   <constraint path="Gene.locations.start" op="==" value="2578486" />
   <constraint path="Gene.locations.end" op="==" value="2580016" />
   <constraint path="Gene.locations.locatedOn.primaryIdentifier" op="==" value="3" />
</query>

would it be better to find any genes that start or end in the specified region instead? You'd certainly know better than me.

rachellyne commented 6 years ago

Yes. You need to put >, <. >=, <= options on the search.

AdrianBZG commented 6 years ago

@yochannah @rachellyne Should we directly use >= for the Start constraints and <= for the End one, or add two selectables, with the 4 options >,<,>=,<= for each one?

yochannah commented 6 years ago

personally I'd prefer the first option - keeping the UI less complex - but @rachellyne would know better than me.

rachellyne commented 6 years ago

I think the first option should be fine.

AdrianBZG commented 6 years ago

@yochannah @rachellyne Done (268815e), check it out in http://im-browser-prototype.herokuapp.com/. If it proceeds, feel free to close this issue 😄

image