Wrong key delimiter in user key column

[shengb]

for user defined column, all keys are combined as one string, which causes issues. For example, I have keys (key1, key2, key3), which shows in keys column as: key1; key2; key3. However, when a user searches the key, it uses space (" ") as delimiter instead of ";". Therefore ";" is treated as part of the key name, which is wrong. It could be simply verified:

1. a user cannot search in order of key3; key2;
2. have to leave space between keys instead of using ";"

[dongliu]

The ; is a delimiter chosen when render the key array. what delimiter do you suggest? I can use a space.

[shengb]

The ; is a good choice. The problem is that it is treated as part of key name after rendering. As above example, when I have key1; key2; key3, I cannot search in the syntax for example key3; key1

[dongliu]

I will then modify the filter context

On Tue, Oct 2, 2018 at 08:53 Guobao Shen notifications@github.com wrote:

The ; is a good choice. The problem is that it is treated as part of key name after rendering. As above example, when I have key1; key2; key3, I cannot search in the syntax for example key3; key1

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/AdvancedPhotonSource/traveler/issues/68#issuecomment-426327322, or mute the thread https://github.com/notifications/unsubscribe-auth/AAklZTZaaxWAP0_x6f1LfZY_YOcQUApqks5ug4vhgaJpZM4XERr9 .

[dongliu]

fixed in https://github.com/AdvancedPhotonSource/traveler/pull/70