search

AgileVentures / EventManager

A system for managing events and hangout participation - microservice API and basic UI
0 stars 5 forks source link

18 More significant change to the view when event goes live #27

Open marianmosley opened 7 years ago

marianmosley commented 7 years ago

fixes #18 ensuring that live status change is visible

mattlindsey commented 7 years ago

hi @marianmosley or @tansaku . Should this PR be working? I tested it, and the class 'live' does not seem to get added where it should.

tansaku commented 7 years ago

@mattlindsey it worked for us and the test passed locally

mattlindsey commented 7 years ago

I see the issue. The class is added for anyone viewing the event, but not for the person who actually made the event live. If this is desired, then I think this PR is ready. Otherwise it needs more work.

tansaku commented 7 years ago

right - at the moment the whole rendering thing is unDry we've got one happening in erb and another in the js

marian and I paired on this and were talking about a js templating setup as a one off client side rendering of the event object ...

mattlindsey commented 7 years ago

Is this still WIP? I tested and looks like initial page (http://localhost:3000/events) still needs reloading to reflect when individual event page is marked 'live'.

And actually it seems if you revisit the individual event page after marking it 'live', the 'event live' words (in red) are missing.

tansaku commented 7 years ago

@mattlindsey myself and @marianmosley were just pairing on this today to refactor the javascript so that the inconsistency you experienced isn't an issue

there is still more to do, specifically: