search

AgreeableDeerGames / GameBackbone

2D game framework
MIT License
11 stars 4 forks source link

CompoundSprite clearComponents should not be virtual #244

Closed lavinrp closed 4 years ago

lavinrp commented 4 years ago

Is your feature request related to a problem? Please describe. The storage of CompoundSprite is defined. There is really only one way to correctly clear its components. Describe the solution you'd like make CompoundSprite::clearComponents non-virtual

lavinrp commented 4 years ago

@gyurgyma While I'm here we have a rather odd line (addComponent(priority, std::move(std::forward<Components>(componentsToAdd))), ...); Do you know if we did std::move(std::forward) for a reason?

lavinrp commented 4 years ago

Up for review: Branch feature/i241-CompSpriteDocs I merged this issue with #241

gyurgyma commented 4 years ago

Reviewed and merged into dev.