search

Aidan275 / nativeqda-dev

NativeQDA
http://dev.nativeqda.xyz/
GNU General Public License v3.0
2 stars 0 forks source link

Login page etc #43

Closed Aidan275 closed 6 years ago

Aidan275 commented 6 years ago

Need to fix the styling on the login page to centre the login form or totally redesign the page, (assignees choice).

Also, need to make the "Complete Survey" link more obvious.

d3nd0 commented 6 years ago

If anyone finds issues please let me know.

d3nd0 commented 6 years ago

Survey Login & Forgot Password pages done in 37143ee

d3nd0 commented 6 years ago

Got to pretty up the css behind the scenes. Also need to use the same design for the reset password form.

Also may use this issue to house a reset password email design as well.

Aidan275 commented 6 years ago

I noticed (I think) the js in the script at the bottom of the page wasn't running on the login page too. You can probably chuck it in the scripts file if you need it, just have to remember the scripts file is added to every page so the classes/ids need to be unique to the login page.

You could add it to the controller but apparently, you're not meant to do any DOM manipulation from controllers in Angular.

d3nd0 commented 6 years ago

Its supposed to add a ripple effect to buttons when you press them. I've never even noticed it on the examples, so I'm happy to just remove the script completely.

Aidan275 commented 6 years ago

Sure, your call.

Couple other little things you've probably noticed already, the placeholder for the email field drops back down over the entered text if it's not a valid email and I added 'object-fit: cover;' to the avatar to get it centring but it doesn't work in IE or Edge :(

d3nd0 commented 6 years ago

I'm pretty sure IE and Edge do not support object-fit

d3nd0 commented 6 years ago

Forgot Password Email design done in 33428c4

d3nd0 commented 6 years ago

The email field on the login page doesn't need to have validation. You won't be able to login with an invalid email address anyway, as email validation is done when a user is Created.

d3nd0 commented 6 years ago

Added angular-css in 6f58a32 to improve convenience and make our view code look a little bit nicer.

d3nd0 commented 6 years ago

Moved css from login-page, forgot-password and complete-survey (enterSurveyCode) to their own css files in assets/css. Put references using angular-css in app.js with commit 6f58a32.