Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform
2 stars 0 forks source link

Figure out what will happen to existing Oracle analyst tables after mapping dates to datetime #4854

Closed edongashi closed 3 years ago

edongashi commented 3 years ago

image

edongashi commented 3 years ago

After updating it returns values including the sub-day component as expected.

sebastian commented 3 years ago

The error with the table needing to be updated, where does it come from? From us or Oracle? Is there a way to avoid this? Analyst table creation can take hours!

sebastian commented 3 years ago

Also, maybe we should add some guidance on how to update the table?

edongashi commented 3 years ago

The error with the table needing to be updated, where does it come from? From us or Oracle?

At first I created a table with the old version of cloak (where D was mapped to date). It worked as expected but lost the time component.

Then I ran this with the new cloak version where D is mapped to datetime. Cloak detected that the analyst table schema no longer matches the underlying data source, thus it says that the table needs to be updated. I updated the table by pressing "Edit" and saving changes without modifying the SQL.

The updated table was queryable and included the time component when queried.

sebastian commented 3 years ago

Ok, then I think we might still want to include a little more guidance on how to update the table. I.e. something to the effect that you need to click edit and re-save the table.

Also we should mark this as a breaking change in the changelog.