search

Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform
2 stars 0 forks source link

Always send ingesting_data query state #4882

Closed edongashi closed 3 years ago

edongashi commented 3 years ago

Fixes #4881

aircloak-robot commented 3 years ago

Standard tests have passed 😊

yoid2000 commented 3 years ago

perfect

On Thu, Feb 4, 2021 at 4:06 PM Edon Gashi notifications@github.com wrote:

@edongashi commented on this pull request.

In air/lib/air_web/templates/changelog/changelog.html.md https://github.com/Aircloak/aircloak/pull/4882#discussion_r570296117:

@@ -1,3 +1,9 @@ +## Version 21.1.1 + +### Enhancements + +- Made execution time of queries more consistent.

Would something like this work?

  • Made execution time of queries more consistent to prevent some types of timing attacks.
  • Debug logs for queries always show the ingesting data state. This prevents an attack where the presence of this line could be used to determine whether a query result contains any rows.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Aircloak/aircloak/pull/4882#discussion_r570296117, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQP5KLCAMYRIYTTQYPYTELS5KZU5ANCNFSM4XCXIFBA .

aircloak-robot commented 3 years ago

Standard tests have passed 👏

aircloak-robot commented 3 years ago

Pull request can be merged 🎉