aircloak-robot
commented
3 years ago air_test job errored 😞
You can see the full build log by running: ci/production.sh build_log pr 4915 air_test
You can restart the build by running: ci/production.sh force_build pr 4915 air_test
You can start the remote console by running: ci/production.sh remote_console pr 4915 air
Log tail:
String.t(),
parameters(),
Air.Service.View.view_map(),
Air.Service.AnalystTable.analyst_table_map()
) :: :ok | {:error, any()}" but it is undefined or private
lib/air_web/socket/cloak/main_channel.ex:24: AirWeb.Socket.Cloak.MainChannel.run_query/8
warning: documentation references "([Map.t()]) :: :ok" but it is undefined or private
lib/air_web/socket/frontend/cloak_stats_channel.ex:9: AirWeb.Socket.Frontend.CloakStatsChannel.broadcast_cloak_stats/1
warning: documentation references "([Map.t()]) :: [Map.t()]" but it is undefined or private
lib/air_web/views/view_helpers.ex:55: AirWeb.ViewHelpers.order_by_id/1
warning: documentation references "()]) :: [Map.t()" but it is undefined or private
lib/air_web/views/view_helpers.ex:55: AirWeb.ViewHelpers.order_by_id/1
warning: documentation references file "elixir-lang.org/" but it does not exist
README.md
warning: documentation references file "../macos_docker.md" but it does not exist
README.md
View "epub" docs at "doc/air.epub"
=> 10 sec
aircloak_ci: `/home/ci/.aircloak_ci/data/cache/builds/pr-4915/src/air/ci/container.sh run_in_container aircloak_ci_hw2yYCXdShycV-N5LO1WLQ make eslint`
cd assets && yarn lint
yarn run v1.22.5
warning package.json: No license field
$ eslint --max-warnings 0 js test && prettier --version && prettier --no-config -c css/**.css "../*.md" "../priv/**/*.md"
2.1.2
Checking formatting...
All matched files use Prettier code style!
Done in 10.91s.
=> 12 sec
aircloak_ci: `/home/ci/.aircloak_ci/data/cache/builds/pr-4915/src/air/ci/container.sh run_in_container aircloak_ci_hw2yYCXdShycV-N5LO1WLQ make flow`
cd assets && node_modules/.bin/flow check
Error ---------------------------------------------------------------------------------------- js/queries/root.js:269:27
Could not decide which case to select, since case 2 [1] may work but if it doesn't case 3 [2] looks promising too. To
fix add a type annotation to object literal [3]. [speculation-ambiguous]
js/queries/root.js:269:27
269| r.id !== id ? r : { ...r, note: note }
^^^^^^^^^^^^^^^^^^^^ [3]
References:
js/queries/result.js:77:5
77| | PendingResult
^^^^^^^^^^^^^ [1]
js/queries/result.js:78:5
78| | CancelledResult
^^^^^^^^^^^^^^^ [2]
Found 1 error
make: *** [Makefile:65: flow] Error 2
=> 75 sec
aircloak_ci: `/home/ci/.aircloak_ci/data/cache/builds/pr-4915/src/air/ci/container.sh run_in_container aircloak_ci_hw2yYCXdShycV-N5LO1WLQ MIX_ENV=test ./check_warnings.sh`
13:13:30.480 [info] Compiling auto-completions
=> 7 sec
aircloak_ci: `/home/ci/.aircloak_ci/data/cache/builds/pr-4915/src/air/ci/container.sh run_in_container aircloak_ci_hw2yYCXdShycV-N5LO1WLQ MIX_ENV=test mix lint`
** (config) Ignoring an undefined check: Credo.Check.Warning.NameRedeclarationByDef
** (config) Ignoring an undefined check: Credo.Check.Warning.NameRedeclarationByFn
** (config) Ignoring an undefined check: Credo.Check.Warning.NameRedeclarationByCase
** (config) Ignoring an undefined check: Credo.Check.Warning.NameRedeclarationByAssignment
Checking 73 source files (this might take a while) ...
info: some checks were skipped because they're not compatible with
your version of Elixir (1.11.1).
You can deactivate these checks by adding this to the `checks` list in your config:
{Credo.Check.Refactor.MapInto, false},
{Credo.Check.Warning.LazyLogging, false},
Code Readability
┃
┃ [R] ↘ There should be no trailing white-space at the end of a line.
┃ test/controllers/query_controller_test.exs:140:1 #(AirWeb.QueryController.Test)
Please report incorrect results: https://github.com/rrrene/credo/issues
Analysis took 2.5 seconds (0.1s to load, 2.4s running 45 checks on 73 files)
228 mods/funs, found 1 code readability issue.
=> 6 sec
aircloak_ci: error:
error running `/home/ci/.aircloak_ci/data/cache/builds/pr-4915/src/air/ci/container.sh run_in_container aircloak_ci_hw2yYCXdShycV-N5LO1WLQ make flow`
error running `/home/ci/.aircloak_ci/data/cache/builds/pr-4915/src/air/ci/container.sh run_in_container aircloak_ci_hw2yYCXdShycV-N5LO1WLQ MIX_ENV=test mix lint`
aircloak_ci: result: `error`
aircloak_ci: finished in 2:23 min
edongashi
Adds support for setting and seeing notes on your queries.
I think this is a good point to split up the PR. The page with all queries and filtering will come later.