search

Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform
2 stars 0 forks source link

Filter live logs by level and source. #4945

Closed cristianberneanu closed 3 years ago

cristianberneanu commented 3 years ago

Closes #4926.

aircloak-robot commented 3 years ago

Standard tests have passed 👏

sebastian commented 3 years ago

And I kind of hate saying so, but these filters would be much better placed in a side filtering panel like all our other filters! It would make our system feel significantly more consistent. It would in fact automatically make our source filter better too as it could become an implicit multi-select thing like how you can select multiple users in the audit log. You could select all the hosts you wanted, and the Air and Cloak option would become entirely redundant.

Of course the log levels would have to be a radio style option where selecting one deselects the previous choice...

cristianberneanu commented 3 years ago

but these filters would be much better placed in a side filtering panel like all our other filters! It would make our system feel significantly more consistent.

It would be more consistent, but also less usable. It would waste a lot of horizontal space, which is pretty valuable when showing the long messages in the logs.

aircloak-robot commented 3 years ago

Standard tests have passed 💯

aircloak-robot commented 3 years ago

Pull request can be merged 👏

cristianberneanu commented 3 years ago

Changed to using ≥. Let me know if you feel strongly about putting the filters on the right side and I will make the change in another PR.

aircloak-robot commented 3 years ago

Standard tests have passed 👏

aircloak-robot commented 3 years ago

Pull request can be merged 👏