search

Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform
2 stars 0 forks source link

Fix filtering by event types #4956

Closed sebastian closed 3 years ago

sebastian commented 3 years ago

A previous change had inadvertently broken the filtering by event types in the audit log. This pull-request fixes this bug in addition to make sure the events terminology is used consistently throughout.

Additionally some dead audit log related code from the previuos non-LiveView version was removed.

aircloak-robot commented 3 years ago

Standard tests have passed ❤️

aircloak-robot commented 3 years ago

Pull request can be merged 👏

sebastian commented 3 years ago

I can't see how this renaming does any fix. Was there a misnamed map key for filters somewhere?

They adapted filter you made was a little too smart. I made the query string based on the names of the keys (event_types in this case) while the server side logic creating the database query looked for event types in the events key.

edongashi commented 3 years ago

Ah, I see. Thanks!