Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform
2 stars 0 forks source link

Make logs downloadable and streamed #4958

Closed edongashi closed 3 years ago

edongashi commented 3 years ago

Fixes #4957.

The logs is now a downloaded file instead of inlined in the browser. A 50+MB file is handled very poorly on browsers.

HTTP chunks are in sync with repo chunks (500).

Fixes a bug where Enum.chunk_every was forcing the whole file to be built in memory before shipping the first chunk.

Gives a nicer style:

image

aircloak-robot commented 3 years ago

Standard tests have passed 👏

edongashi commented 3 years ago

The scroll formula is now off. How did you get the calc(100vh - 8px - 26.25em); value?

aircloak-robot commented 3 years ago

Standard tests have passed 😊

edongashi commented 3 years ago

Guessed it to -27.25em and it looks somewhat correct.

aircloak-robot commented 3 years ago

Standard tests have passed ❤️

aircloak-robot commented 3 years ago

Pull request can be merged 💯

cristianberneanu commented 3 years ago

Guessed it to -27.25em and it looks somewhat correct.

Makes sense, controls are now 1em bigger, since you dropped the small tag.