search

Aircloak / aircloak

This repository contains the Aircloak Air frontend as well as the code for our Cloak query and anonymization platform
2 stars 0 forks source link

Group result note edit and delete buttons. #4961

Closed cristianberneanu closed 3 years ago

cristianberneanu commented 3 years ago

The note edit button was previously next to the result delete button, which I think is a bit confusing. This is an alternative to the current layout:

image image

aircloak-robot commented 3 years ago

Standard tests have passed 👏

cristianberneanu commented 3 years ago

I also think we need to put a tooltip (or regular title attribute) to let the user know what this button will do. Not strictly related to this PR and can be done later (for delete query button as well).

I added tooltips for the add/edit note buttons. I didn't add tooltips for the delete result/note buttons, as they have a buggy behavior that I couldn't work around: after the button is clicked and the component is removed, the tooltip remains on screen.

edongashi commented 3 years ago

I didn't add tooltips for the delete result/note buttons, as they have a buggy behavior that I couldn't work around: after the button is clicked and the component is removed, the tooltip remains on screen.

Probably because we're using blocking confirm calls. Not a big deal because the X is obvious enough.

aircloak-robot commented 3 years ago

Standard tests have passed 🎉

aircloak-robot commented 3 years ago

Pull request can be merged 👏