Closed IanMitchell77 closed 4 years ago
Thanks for the great idea. How are you trying to solve this at the player level? Our PR is always open.
Hi,
I haven’t looked at the code yet but I plan that when the switch happens it creates a new buffer in parallel to the old buffer and only decodes and switches display when the new buffer has enough data to decode – then the old buffer is discarded.
This will take a while but will be a much nicer user experience – the downside is that it would consume more data during the switch time.
I am an embedded software engineer, writing in C/C++ mostly so its a steep learning curve for me so any help of points are much appreciated.
I am not sure what I do now – can I now checkout a branch for this PR and hopefully get some community help?
Thanks,
Ian
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Jeheon Hanmailto:notifications@github.com Sent: 08 May 2020 13:00 To: AirenSoft/OvenPlayermailto:OvenPlayer@noreply.github.com Cc: Ian Mitchellmailto:mitch_work@hotmail.com; Authormailto:author@noreply.github.com Subject: Re: [AirenSoft/OvenPlayer] Seamless switching streams (#118)
Thanks for the great idea. How are you trying to solve this at the player level? Our PR is always open.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/AirenSoft/OvenPlayer/issues/118#issuecomment-625781721, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYLTOTSOWOTFLFZDF2OFSLRQPX6XANCNFSM4M2SXR5Q.
@IanMitchell77 You can checkout master branch for PR. Thank you.
Please refer to the following url for pull request. https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request
This issue has been closed since it has been inactive for quite some time. If you want to continue discussing this issue, please feel free to reopen it.
Hi,
Id like to be able to switch streams seamlessly, an approach is start receiving as soon as the player is told but only start decoding/displaying when there is enough data.
Then further we could optimise the switching algorithm so that the player switches on its own, up quality when the buffer is full and reduce quality if the buffer is nearly empty maybe.
Please discuss solutions and where I might modify the source - this is my first contribution ;)
Thanks,
Ian