search

AirenSoft / OvenPlayer

OvenPlayer is JavaScript-based LLHLS and WebRTC Player for OvenMediaEngine.
https://airensoft.com/ome.html
MIT License
514 stars 126 forks source link

Hardcoded DNS Server #142

Closed larssorenson closed 3 years ago

larssorenson commented 4 years ago

Hey,

It looks like the JavaScript player hard codes to use dns.google.com to resolve the backend server:

https://github.com/AirenSoft/OvenPlayer/blob/d74cd4ee5ef01fbf56413f2fd4059eac201a0af0/src/js/api/provider/html5/providers/WebRTCLoader.js#L370

As well as a hard-coded google STUN server:

https://github.com/AirenSoft/OvenPlayer/blob/d74cd4ee5ef01fbf56413f2fd4059eac201a0af0/src/js/api/provider/html5/providers/WebRTCLoader.js#L23

This makes the player unusable when users have Google sources/domains blocked.

It would be nice if this could be configured or bypassed without having to ad-hoc patch the JavaScript.

Thanks

getroot commented 4 years ago

Very good idea! We will update this.

SangwonOh commented 3 years ago

@larssorenson Hard coded google STUN server was removed. User can be able to set any STUN server if they need with player configuration. And also dns.google.com can be bypassed with player configuration. But we've not removed DNS resolving feature using google DNS resolving service. For, OvenPlayer resolves DNS using google's service by the default and if user want to resolve DNS by their methods, bypass auto resolving and set the WebRTC connection URL with their resolved DNS.