AlanOC91 / YGOPRODeck

Yu-Gi-Oh! Card Database and Deck Share Site
80 stars 4 forks source link

Card Collection #128

Closed AlanOC91 closed 2 years ago

AlanOC91 commented 4 years ago

Look into adding the functionality of card collection tracking.

This would allow users to create a custom list of cards they own in their collection.

Minimum required info:

We'll also need a login system to keep the information stored. This is the bigger issue. The database db.ygoprodeck.com currently uses no login system. Ygoprodeck uses a login system and I could try cross sync them but this is messy. Will need to investigate. I already have an offline login system created for it but not implement or tested fully yet.

AlanOC91 commented 4 years ago

Alpha Collection Tracking now in place.

What it does currently:

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

Current Bugs:

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

Rework price check to match card set code instead of card set name. This is done due to difference in card set naming schemes from tcgplayer.

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

TODO:

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

Added a decent bit of error checking to the CSV Import.

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

The 3 are: Sort by Name (A-Z), Sort by Rarity and Sort by Quantity. I have an almost working sort by price but there is a few quirks with it.

SearchCollection

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

Logged Out

AlanOC91 commented 4 years ago
AlanOC91 commented 4 years ago

NOTE: This will have a slight adverse affect on those who have added cards to set names that don't exactly match. For example the old system used "Legend of Blue Eyes White Dragon" while the new system uses "The Legend of Blue Eyes White Dragon". It won't break anything but when you click on the set name to search it will return 0 results if using the old name.

AlanOC91 commented 4 years ago

This required a bit of a structural overhaul on the database as I needed to add a unique key to the database. Once this was done, I then needed to update each script with an ON DUPLICATE KEY UPDATE clause. I then needed to update the JavaScript code to handle incrementing the count if a card match the key already exists when inserting.

Everything should be working with the exception of csv import. This is currently disabled as I need to re-write it now.

This change was required (and a good change regardless) for syncing the Pack Opener.

AlanOC91 commented 4 years ago
AexDEye9 commented 4 years ago

i've wanted the ability to share your collection in-site/externally ever since the collection feature was added, when do you think this might be added?

AlanOC91 commented 4 years ago

What kind of share options are you thinking of? We can currently export to PDF but I've been considering allowing you to share some form of URL link too.

ghost commented 4 years ago

Hi! I was wondering if we could get "Price Collection from Cardmarket" option for Europe players in card collection section :) ?

AlanOC91 commented 4 years ago

Hi! I was wondering if we could get "Price Collection from Cardmarket" option for Europe players in card collection section :) ?

I can look into this for sure but our Cardmarket pricing is a little bit trickier since we don't have completely accurate pricing for 1st Edition/Unlimited. I'll check it out though!

AlanOC91 commented 3 years ago
AlanOC91 commented 3 years ago
AlanOC91 commented 3 years ago

We have some issues with performance when users have really large datasets. I've spent most of the morning trying to code an optimal code re-write solution but due to the nature of the collection system, none performed well.

The only option is to add some form of pagination to the user collection. This involves:

AlanOC91 commented 3 years ago

While I am working on the above, I deployed a temporary work-around fix that optimizes loading of large data-sets in the collection manager. This is now live.

SlaggyWolfie commented 3 years ago

Would it be possible to export your entire collection through .ydk file or a way to convert the .csv collection to a .ydk? Granted I could do this myself, but my friends are not as tech-savvy. I'm mainly asking because it's already possible to download the drafts from the entire set as a .ydk. In this case, I understand that it might not be possible because only automatic simulators usually have the capability to display that many cards at a single time. I theorize it might become necessary to split up all the cards into multiple .ydk files.

Or alternatively, allow for the deck builder to only be able to access the collection for deckbuilding purposes. The reason I'm asking is for a progression series with my friends, for which I apologize that it's for such an activity, and I apologize for this sort of feature request. I understand it if it's not currently on the radar or unfeasible.

AlanOC91 commented 3 years ago

Would it be possible to export your entire collection through .ydk file or a way to convert the .csv collection to a .ydk? Granted I could do this myself, but my friends are not as tech-savvy. I'm mainly asking because it's already possible to download the drafts from the entire set as a .ydk. In this case, I understand that it might not be possible because only automatic simulators usually have the capability to display that many cards at a single time. I theorize it might become necessary to split up all the cards into multiple .ydk files.

Or alternatively, allow for the deck builder to only be able to access the collection for deckbuilding purposes. The reason I'm asking is for a progression series with my friends, for which I apologize that it's for such an activity, and I apologize for this sort of feature request. I understand it if it's not currently on the radar or unfeasible.

Howdy SlaggyWolfie.

Firstly, we are currently working on a format filter (such as TCG, OCG, etc) for "Card Collection" on the Deck Builder. This will basically allow you to query your Collection through the Deck Builder interface which will make building decks out of your Collection much easier!

This should solve your problem.

Alternatively in theory I could generate a .ydk file out of the collection. However many system do generally have limits on main deck size and so on.

AlanOC91 commented 3 years ago

(this is not a replacement for our future plan of adding a "Collection" format to our online deck builder that will query your collection)

Builder deck

cmiley commented 3 years ago

Would it be possible to add a way to select edition while adding a card? Sometimes its confusing when adding a card that has the same set code (that is already in your collection) but of a different edition.

Ex. SDJ-001 1st Edition vs Unlimited