Closed AlejandroSantorum closed 1 year ago
Actually, the argument bins
is thought to be of type Union[int, sequence]
so changing the name to n_bins
is discarded. Instead, make sure it is not over-written by the return values of the numpy method np.histogram
.
Similarly, rename the input argument bins
of skrmt.ensemble.utils.plot_func
to n_bins
since in this case the only permitted type is int
. This function does not use np.histogram
, since it is not plotting a histogram but a function.
Currently, the methods to compute the eigenvalue histogram (
eigval_hist
) and to plot it (plot_eigval_hist
) use an input argument calledbins
of typeint
. This follows the same style as numpy (np.histogram): https://numpy.org/doc/stable/reference/generated/numpy.histogram.htmlHowever, the name is not informative nor clear enough. To avoid inconsistencies, I propose to rename this input argument to
nbins
orn_bins
. Additionally, make sure inside the code the input argumentbins
is not over-written by the return of the numpy methodnp.histogram
: DO NOT WRITE:observed, bins = np.histogram(...)